Closed Bug 763493 Opened 12 years ago Closed 12 years ago

Bookmarks Manager has lost its icons

Categories

(SeaMonkey :: Bookmarks & History, defect)

Product:
SeaMonkey
Component:
Bookmarks & History
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(seamonkey2.10 wontfix, seamonkey2.11 fixed, seamonkey2.12 fixed)

Status:
RESOLVED FIXED
Milestone:
seamonkey2.13
Tracking Flags:
Tracking Status
seamonkey2.10 --- wontfix
seamonkey2.11 --- fixed
seamonkey2.12 --- fixed

People

(Reporter: neil, Assigned: neil)

References

Details

(Keywords: regression)

Attachments

(3 files)

Proposed patch
3.56 KB, patch
iannbugzilla
: review+
Details | Diff | Splinter Review
Packaging fix?
4.07 KB, patch
Callek
: review+
Details | Diff | Splinter Review
Rolled-up patch for branch
7.61 KB, patch
iannbugzilla
: approval-comm-aurora+
iannbugzilla
: approval-comm-beta+
Details | Diff | Splinter Review
The Bookmarks manager window and the bookmark properties dialog used to have custom window icons, but these stopped working when the appropriate windows were given new ids by bug 580662. I guess it's too late to change the ids back, so we have to rename the icons instead. I don't know how the Mac works though.
Attached patch Proposed patch — — Splinter Review
Assignee: nobody → neil
Status: NEW → ASSIGNED
Attachment #631894 - Flags: review?(iann_bugzilla)
Comment on attachment 631894 [details] [diff] [review] Proposed patch r=me assuming you get a ui-review from a mac person
Attachment #631894 - Flags: review?(iann_bugzilla) → review+
Mac doesn't make use of window icons and the the Mac icons in suite/branding/nightly/icons/mac/ are handled in suite/app/macbuild/Contents/Info.plist.in, so you can just move on :-)
Pushed comm-central changeset b12ec5c00ac0.
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Comment on attachment 631894 [details] [diff] [review] Proposed patch [Approval Request Comment] Regression caused by (bug #): 580662 User impact if declined: Cosmetic Testing completed (on m-c, etc.): None Risk to taking this patch (and alternatives if risky): Low (build fix) String changes made by this patch: None
Attachment #631894 - Flags: approval-comm-beta?
Attachment #631894 - Flags: approval-comm-aurora?
http://tinderbox.mozilla.org/showlog.cgi?log=SeaMonkey/1339686418.1339695615.3577.gz&fulltext=1 make[3]: *** [stage-package] Error 255 Error: package error or possible missing or unnecessary file: bin/chrome/icons/default/bmPropsWindow.png (package-manifest, 348). Error: package error or possible missing or unnecessary file: bin/chrome/icons/default/bmPropsWindow16.png (package-manifest, 349). Error: package error or possible missing or unnecessary file: bin/chrome/icons/default/bmPropsWindow48.png (package-manifest, 350). Error: package error or possible missing or unnecessary file: bin/chrome/icons/default/bookmark-window.png (package-manifest, 351). Error: package error or possible missing or unnecessary file: bin/chrome/icons/default/bookmark-window16.png (package-manifest, 352). Error: package error or possible missing or unnecessary file: bin/chrome/icons/default/bookmark-window48.png (package-manifest, 353).
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Comment on attachment 631894 [details] [diff] [review] Proposed patch FYI: Packaging errors are now fatal.
Attachment #631894 - Flags: approval-comm-beta?
Attachment #631894 - Flags: approval-comm-beta-
Attachment #631894 - Flags: approval-comm-aurora?
Attachment #631894 - Flags: approval-comm-aurora-
> FYI: Packaging errors are now fatal.
Attached patch Packaging fix? — — Splinter Review
Attachment #633422 - Flags: review?(sgautherie.bz)
Comment on attachment 633422 [details] [diff] [review] Packaging fix? I skimmed it, and looks fine, and briefly compared against win
Attachment #633422 - Flags: review?(sgautherie.bz) → review+
Attachment #631894 - Flags: approval-comm-beta?
Attachment #631894 - Flags: approval-comm-beta-
Attachment #631894 - Flags: approval-comm-aurora?
Attachment #631894 - Flags: approval-comm-aurora-
Pushed comm-central changeset 4cf03f36c629.
Status: REOPENED → RESOLVED
Closed: 12 years ago → 12 years ago
Resolution: --- → FIXED
[Approval Request Comment] Regression caused by (bug #): 580662 User impact if declined: Cosmetic Testing completed (on m-c, etc.): Landed and bustage fixed Risk to taking this patch (and alternatives if risky): Low (bustage fixed) String changes made by this patch: None
Attachment #633982 - Flags: approval-comm-beta?
Attachment #633982 - Flags: approval-comm-aurora?
Attachment #631894 - Flags: approval-comm-beta?
Attachment #631894 - Flags: approval-comm-aurora?
status-seamonkey2.10: --- → wontfix
status-seamonkey2.11: --- → affected
status-seamonkey2.12: --- → affected
Flags: in-testsuite-
Target Milestone: --- → seamonkey2.13
Attachment #633982 - Flags: approval-comm-beta?
Attachment #633982 - Flags: approval-comm-beta+
Attachment #633982 - Flags: approval-comm-aurora?
Attachment #633982 - Flags: approval-comm-aurora+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: