Using nsIPrincipal::Subsumes instead of nsIPrincipal::Equals in nsDocShell

RESOLVED FIXED in mozilla16

Status

()

Core
Document Navigation
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: krizsa, Unassigned)

Tracking

unspecified
mozilla16
x86_64
Windows 7
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

5 years ago
After inventing nsExpandedPrincipal in bug 734891 it can cause some issues with it that at various places of the platform there is Equals used for security checked where conceptually Subsumes should be. 

One of it is in nsDocShell the bug was reported here: https://bugzilla.mozilla.org/show_bug.cgi?id=734891#c86
Which actual callsite in docshell is this?
Component: XPConnect → Document Navigation
QA Contact: xpconnect → docshell
(Reporter)

Comment 2

5 years ago
(In reply to Boris Zbarsky (:bz) from comment #1)
> Which actual callsite in docshell is this?

http://mxr.mozilla.org/mozilla-central/source/docshell/base/nsDocShell.cpp#7932

And thanks for putting the bug into the right place, I was wondering where to file it.
Ah, yes.  That should totally be Subsumes.
(Reporter)

Comment 4

5 years ago
Created attachment 632149 [details] [diff] [review]
Using nsIPrincipal::Subsumes instead of nsIPrincipal::Equals in nsDocShell

https://tbpl.mozilla.org/?tree=Try&rev=1d034734aa86
Attachment #632149 - Flags: review?(bobbyholley+bmo)
Comment on attachment 632149 [details] [diff] [review]
Using nsIPrincipal::Subsumes instead of nsIPrincipal::Equals in nsDocShell

To clarify, I'm not a peer here.
Attachment #632149 - Flags: review?(bobbyholley+bmo) → review?(bzbarsky)
Comment on attachment 632149 [details] [diff] [review]
Using nsIPrincipal::Subsumes instead of nsIPrincipal::Equals in nsDocShell

r=me
Attachment #632149 - Flags: review?(bzbarsky) → review+
(Reporter)

Updated

5 years ago
Keywords: checkin-needed
https://hg.mozilla.org/integration/mozilla-inbound/rev/7612eef1ed3a
Flags: in-testsuite-
Keywords: checkin-needed
Target Milestone: --- → mozilla16

Comment 8

5 years ago
https://hg.mozilla.org/mozilla-central/rev/7612eef1ed3a
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.