763509 - Users can add location info to profiles

Status: VERIFIED FIXED

(Participation Infrastructure :: Phonebook, defect)

Description

[James Socol [:jsocol, :james]]

Attachment: what the form looks like now

In this bug, we cover the ability to add optional location data to the phonebook profile. For now, we're sticking with:

Country/Region
State/Province
City

It seems to make sense to require that if you set one, you must sett all the less-specific ones. But that may be unnecessary. Thoughts?

Using product_details, we have a localized list of countries to choose from, based on the current request's locale.

Comment 1

[James Socol [:jsocol, :james]]

Looking for feedback on UX for a couple things:

- Strings. I want to be politically neutral, so I said "Country/Region". I don't know if we have a official stance or style-guide for how to refer to those. Then I said "State/Province" which is hopefully generic enough. But the slashes may not be appropriate (" or " instead?). So, Bram, thoughts?

- Is it worth putting some text above the location fields, something to the effect of "Let us know where in the world you are, and connect with other local Mozillians!" I think we talked about the goal of motivating people to give us this info because it will benefit _them_, not just us.

- Should location be its own tab, with more room for text? People don't read, so I don't know if text is really valuable, but it's an option.

- Currently, you can't add a city without a district, or a district without a country. (I.e., you need the least-specific before you can get more specific.) I was unsure if that's useful validation, so I added that now, since it will be far, far easier to relax than to tighten up later.

Comment 2

[James Socol [:jsocol, :james]]

https://github.com/mozilla/mozillians/pull/257

Comment 3

[Aakash Desai [:aakashd]]

    * Strings - Pierros, our resident expert on location terminology, suggested using the following use "Country" (in place of Country/Region) and "Region" (in place of State/Province).

    * Yes, its worth putting in that text above the location fields (or as a tooltip)

    * Location is a-ok on the profile tab; its not big enough to be put onto its own tab. Plus, we're risking adding too many things to tabs with the addition of the Services tab as well. Also, we're not going to do more with location (other than privacy) based off of the roadmap.

    * Good thinking on keeping this relaxed to users. The less obstacles and the smarter the field, the better the experience.

Comment 4

[Bram Pitoyo [:bram]]

For the best user experience, I would go with:
* Region (optional, drop-down menu)
* Country (drop-down menu)
* State/Province (drop-down menu, more on this later)
* City (text box)

Q: Why go with drop-down menus?
A: To control the vocabulary, eliminate spelling variations and make search by location simpler to do (a tag-listing rather than a string search.)

Q: Why the region? Why is it optional?
A: It’s uncommon, but it is implemented on sites with wide international support (http://www.ikea.com/).

The pros of a separate region field:
* User doesn’t have to reveal his country
* It makes narrowing down by country easier (the items under country are narrowed down based on the region picked)

The cons of a separate region field:
* Picking a country rather than a region is the interaction that virtually all users are comfortable doing (a lot of registration steps ask for country)
* Regions might not useful. Can we justify the value of getting the numbers and listing of all Mozillians in Asia, Europe or Latin America? The scenario that I could see this being useful is for regional MozCamp planning, but even then, we are looking at a subset of Mozillians, not everyone in the list.

My recommendation is to just go with a Country field and say “no” to region unless we can justify its implementation, as selecting a country is an operation that a majority of users are comfortable doing.

Comment 5

[Aakash Desai [:aakashd]]

Drop-down menu's for "Country"  (and possible region and city) seem to be the general trend. Here are some examples:

* https://github.com/coderholic/django-cities
* https://github.com/mozilla/remo/blob/master/remo/profiles/templates/profiles_edit.html#L171

Comment 6

[James Socol [:jsocol, :james]]

Responses to questions/concerns:

- Country is a drop-down right now, I thought that was visible in the screenshot. It's even a localized drop-down (e.g., if you're on fr/profile/edit, you see états-unis, instead of "United States").

- My only concern with the label "country" was political (been bit by that before), but if it's what we go with, then I'll change it.

- I agree with Bram that a separate region field isn't worth it, at least right now. We can infer region from country, if people aren't comfortable giving us the country, oh well.


My questions.

- Can we please make Region (née State/Province) a drop-down in a follow-up? That's a lot of data and client-side coding and we're on a deadline here.

- What copy should I put above the location fields?

Comment 7

[Bram Pitoyo [:bram]]

(In reply to James Socol [:jsocol, :james] from comment #6)
> - My only concern with the label "country" was political (been bit by that
> before), but if it's what we go with, then I'll change it.

If this is an issue, I have no problem calling it “country/region”. My concern is that the drop-down menu does not contain region in it?

> - Can we please make Region (née State/Province) a drop-down in a follow-up?
> That's a lot of data and client-side coding and we're on a deadline here.

Yep. Would it be doable to map and migrate fields later?

> - What copy should I put above the location fields?

One of my mockups had “Biography” and “Geography” to indicate what’s above and below the location-based stuff, but I scrapped it. There are not enough fields for the form to require some sort of an order.

Another proposal is to put location as a separate tab, much like how Skills & Groups are also present on the profile page, but is tweaked separately from profile information.

Putting it on a separate tab might mean more design consistency. But if it is hard to code, I wouldn’t worry about it for now.

Comment 8

[Aakash Desai [:aakashd]]

Agree with bram on it all except for the tab, how about using headers like what was done for "Groups" & "Skills" ?

The headers could be "Personal" and "Location".

Comment 9

[Aakash Desai [:aakashd]]

Attachment: Rough Sketch Mock-up

Comment 10

[Aakash Desai [:aakashd]]

Attachment: Rough Sketch Mock-up 2

Comment 11

[[github robot]]

Commit pushed to master at https://github.com/mozilla/mozillians

https://github.com/mozilla/mozillians/commit/367be2f7cb55c67df4576df0beddc7138ed88ceb
[fix bug 763509] Add location to profiles.

Users can add country/region, state/province, and city to their profile.
The data isn't displayed on the profile anywhere--let's do that in a
follow-up: this is the important part for right now.

You can't specify a specific region without specifying a more general
one. For example, you can't list a state without a country, or a city
without a state.

Includes tests.

Comment 12

[Aakash Desai [:aakashd]]

Verified:

* I can add all three locations individually as well as all together.
* I cannot enter locations unless their superset has been selected (i.e. No region/city without country, etc.)