Closed Bug 763610 Opened 8 years ago Closed 4 years ago

test_name_extension should probably go away

Categories

(Testing :: Talos, defect)

defect
Not set

Tracking

(firefox49 fixed)

RESOLVED FIXED
mozilla49
Tracking Status
firefox49 --- fixed

People

(Reporter: k0scist, Assigned: malayaleecoder)

References

Details

(Whiteboard: [talos_wishlist])

Attachments

(1 file)

We have a configuration variable, test_name_extension, that will be
appended to the test name and counter names *only* for tp tests.  As
far as I know, this is not used in production and provides extra
complication.
This is not settable from the CLI but values like _paint and _nochrome are added from PerfConfigurator.py . If we can't eliminate this altogether, it would help if we could at least do this for ts tests as well as tp tests
Also, once datazilla is a reality and graphserver is obseleted these can go away (along with a helluva lot more other stuff)
sadly this bug still exists- when we stop uploading to graph server, this can go away- maybe a few more months!
ok, graph server is not being used anymore, we can move forward on this bug!
Whiteboard: [talos_wishlist]
I would like to give this a try :)
Assignee: nobody → malayaleecoder
The tests pass locally, please push to try and verify there also :)
the try push looks good- if you think the patch is ready, please edit the details of the attachment and ask me for review :)
Attachment #8755594 - Flags: review?(jmaher)
Status: NEW → ASSIGNED
Comment on attachment 8755594 [details] [diff] [review]
Bug763610_v1.diff

Review of attachment 8755594 [details] [diff] [review]:
-----------------------------------------------------------------

thanks, this is a great first patch for talos!
Attachment #8755594 - Flags: review?(jmaher) → review+
https://hg.mozilla.org/mozilla-central/rev/0b2a710d35e6
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla49
You need to log in before you can comment on or make changes to this bug.