test_name_extension should probably go away

RESOLVED FIXED in Firefox 49

Status

Testing
Talos
RESOLVED FIXED
6 years ago
2 years ago

People

(Reporter: Jeff Hammel, Assigned: malayaleecoder)

Tracking

unspecified
mozilla49
Points:
---

Firefox Tracking Flags

(firefox49 fixed)

Details

(Whiteboard: [talos_wishlist])

Attachments

(1 attachment)

(Reporter)

Description

6 years ago
We have a configuration variable, test_name_extension, that will be
appended to the test name and counter names *only* for tp tests.  As
far as I know, this is not used in production and provides extra
complication.
(Reporter)

Comment 1

6 years ago
This is not settable from the CLI but values like _paint and _nochrome are added from PerfConfigurator.py . If we can't eliminate this altogether, it would help if we could at least do this for ts tests as well as tp tests
(Reporter)

Comment 2

6 years ago
Also, once datazilla is a reality and graphserver is obseleted these can go away (along with a helluva lot more other stuff)
sadly this bug still exists- when we stop uploading to graph server, this can go away- maybe a few more months!
ok, graph server is not being used anymore, we can move forward on this bug!
Whiteboard: [talos_wishlist]
Blocks: 1088251
(Assignee)

Comment 5

2 years ago
I would like to give this a try :)
Assignee: nobody → malayaleecoder
(Assignee)

Comment 6

2 years ago
Created attachment 8755594 [details] [diff] [review]
Bug763610_v1.diff

The tests pass locally, please push to try and verify there also :)
push to try:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=ca7ae59fd8d4
the try push looks good- if you think the patch is ready, please edit the details of the attachment and ask me for review :)
(Assignee)

Updated

2 years ago
Attachment #8755594 - Flags: review?(jmaher)
(Assignee)

Updated

2 years ago
Status: NEW → ASSIGNED
Comment on attachment 8755594 [details] [diff] [review]
Bug763610_v1.diff

Review of attachment 8755594 [details] [diff] [review]:
-----------------------------------------------------------------

thanks, this is a great first patch for talos!
Attachment #8755594 - Flags: review?(jmaher) → review+
Keywords: checkin-needed

Comment 10

2 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/0b2a710d35e6
Keywords: checkin-needed

Comment 11

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/0b2a710d35e6
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
status-firefox49: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla49
You need to log in before you can comment on or make changes to this bug.