76382 - Disable the Properties toolbar button and menu item when focus is on Address Book

Status: VERIFIED WORKSFORME

(SeaMonkey :: MailNews: Address Book & Contacts, defect, P3)

Description

[fenella]

Linux (2001-04-17-08 trunk)
Win32 (2001-04-17-06 trunk)
Mac (2001-04-17-04 trunk)
1. Open Address Book from the Task menu
2. Set focus on the Personal address book
3. Select Edit|Card Properties.
Actual result: It does not bring up the dialog for the Personal Address Book.  
Instead, it brings up the "Card for the card or list" that has the focus set on 
the result pane.

Expected result: Per spec.,  it should bring up the property dialog for the 
Address Book because I have set focus on the Personal Address Book.

This occurs on all three platforms.

Comment 1

[jglick]

Edit "Card Properties..." should be "Address Book Properties..." when an AB has 
focus.

http://www.mozilla.org/mailnews/specs/addressbook/AB_Menus.html

Comment 2

[jglick]

I know this probably won't make beta, but rtm would be nice (was sure how to 
nominate it for rtm).

Address Book is not as high profile as other components, but the current 
behavior is wrong and should be fixed.

Comment 3

[scottputterman]

marking nsbeta1+ and moving to 0.9.2

Comment 4

[chuang]

Scott and I talked and we decide to do a simple fix on this bug instead of 
implement the edit address book property.   The fix will disable the Edit button 
and Card properties menu item when user click on the left pane.

Comment 5

[chuang]

Attachment: Patch for disable the edit button and menu item

Comment 6

[scottputterman]

moving to 0.9.3. Please hold onto the fix in case we can get this in later.

Comment 7

[jglick]

If this bug does end up disabling the Properties menu item when an Address Book 
has focus, please be sure to create a different bug for adding this feature back 
in at a later time. (or create a different bug to disable the menu item as a 
temporary solution)

Comment 8

[chuang]

Bug 60370 is a dup for this one.

Comment 9

[chuang]

Change summary to reflect the fix for this bug,  bug 60370 now is for "Address
Book Properties...".

Comment 10

[scottputterman]

moving to 0.9.4

Comment 11

[scottputterman]

moving to 0.9.5

Comment 12

[scottputterman]

moving to 0.9.6

Comment 13

[scottputterman]

reassigning to racham

Comment 14

[scottputterman]

moving to 1.0, though if we could get the patch in it would be good.

Comment 15

[(not reading, please use [e-mail] instead)]

Comment on attachment 35975 [details] [diff] [review]
Patch for disable the edit button and menu item

what ever this patch is, I'm sure it's obsolete.

Comment 16

[(not reading, please use [e-mail] instead)]

is this bug invalid?

We now have a Properties toolbar button and a Properties menu item, and those
work when the directory tree has focus. (at least, when mailing list is selected.)

at some point, they should work for addressbooks, as local addressbooks will
have editable properties (name) and LDAP addressbooks will have properties (SSL
or non-SSL, port, host, name, etc.)

Comment 17

[jglick]

Seth, this bug was originally writen because an AB can be selected, the 
"Properites" button/menu item is enabled, but clicking does nothing. Instead of 
fixing it, bug was morphed into "Disable the Properties menu/button when an AB 
has focus".

Both issues are still valid. #1 was a temp fix. #2 is the permanent/correct fix.

1. If an AB has focus, but "Properties" button/menu doesn't work yet, we should 
disable the button/menu.
2. AB selected, "Properties" button/menu clicked should open "Address Book 
Properites" dialog.

Comment 18

[jglick]

bug 17230 is for implementing the AB Properties dialog.

Comment 19

[Ninoschka Baca]

Marking nsbeta1, see comment# 17 for implementation.

Comment 20

[Samir Gehani]

Mail triage team: nsbeta1+/adt3

Comment 21

[Cavin Song]

Reassigning.

Comment 22

[shliang]

clicking properties now brings up the rename addressbook dialog (bug #17230)

Comment 23

[Ninoschka Baca]

Trunk build 2003-05-20: WinMe, Mac 10.1.5, Linux RH 8
Verified Worksforme.