76384 - Crash in the default plugin

Status: VERIFIED FIXED

(Core Graveyard :: Plug-ins, defect, P2)

Description

[av (gone)]

1. Go to a page with unknown plugin
2. Have Get Plugin dialog poped up
3. Click on the puzzle peace again, you will another Get Plugin
4. Leave the page and  observe the crash

Comment 1

[av (gone)]

Patch is coming...

Comment 2

[av (gone)]

The following patch in CPlugin::showGetPluginDialog will prevent duplicate 
copies of the dialog:

  if((m_szPageURL != NULL) || (m_szFileURL != NULL) || !m_bJavaScript)
  {
+    // we don't want it more than once
+    if(m_hWndDialog == NULL)
      CreateDialogParam(m_hInst, MAKEINTRESOURCE(IDD_PLUGIN_DOWNLOAD), m_hWnd,
                        (DLGPROC)GetPluginDialogProc, (LPARAM)this);
  }
+  else
+    getPlugin();

Also note the ``else'' statement addition which should also be here or 
JavaScript window will not pop up instead of the native dialog when needed. This 
was a regression when we changed the dialog from modal to modeless.

Comment 3

[Marc Attinasi]

OK - sr=attinasi

Comment 4

[av (gone)]

Checked in. Marking fixed.

Comment 5

[shrirang khanzode]

verifd in 0419 build.