Last Comment Bug 763911 - Support interface members in dictionaries
: Support interface members in dictionaries
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: DOM (show other bugs)
: unspecified
: x86 Mac OS X
: -- normal (vote)
: mozilla16
Assigned To: Boris Zbarsky [:bz] (Out June 25-July 6)
:
Mentors:
Depends on:
Blocks: ParisBindings 764398
  Show dependency treegraph
 
Reported: 2012-06-12 07:18 PDT by Boris Zbarsky [:bz] (Out June 25-July 6)
Modified: 2012-06-20 02:21 PDT (History)
3 users (show)
bzbarsky: in‑testsuite+
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Add support for interface members of dictionaries. (20.80 KB, patch)
2012-06-12 11:03 PDT, Boris Zbarsky [:bz] (Out June 25-July 6)
khuey: review+
Details | Diff | Review

Description Boris Zbarsky [:bz] (Out June 25-July 6) 2012-06-12 07:18:43 PDT
Need to pass the config to dictionary init, as well as the workers bool, so it can get providers as needed.  Or maybe it's enough to hang a getDescriptorProvider(workers) off the config and pass that in here.
Comment 1 Boris Zbarsky [:bz] (Out June 25-July 6) 2012-06-12 11:03:54 PDT
Created attachment 632325 [details] [diff] [review]
Add support for interface members of dictionaries.
Comment 2 Kyle Huey [:khuey] (khuey@mozilla.com) 2012-06-18 10:50:25 PDT
Comment on attachment 632325 [details] [diff] [review]
Add support for interface members of dictionaries.

Review of attachment 632325 [details] [diff] [review]:
-----------------------------------------------------------------

We should move to lazily generated dictionary bindings and drop this 'generatable' stuff eventually, but for now, this is fine.
Comment 3 Boris Zbarsky [:bz] (Out June 25-July 6) 2012-06-19 09:12:28 PDT
https://hg.mozilla.org/integration/mozilla-inbound/rev/fe05699b8835
Comment 4 Ed Morley [:emorley] 2012-06-20 02:21:44 PDT
https://hg.mozilla.org/mozilla-central/rev/fe05699b8835

Note You need to log in before you can comment on or make changes to this bug.