makefiles: stray parenthesis character in the check_XinY.mk unit test

RESOLVED FIXED in mozilla16

Status

()

Core
Build Config
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: joey, Unassigned)

Tracking

unspecified
mozilla16
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

5 years ago
::: config/makefiles/test/check_XinY.mk
@@ +23,5 @@
>  # verify strcmp('clean')
>  val  := clean
>  $(call errorifneq,$(zero),$(words $(call is_XinY,foo,$(val))))
>  $(call errorifneq,$(one),$(words $(call is_XinY,clean,$(val))))
> +$(call errorifneq,$(one),$(words $(call is_XinY,clean%,$(val))))

Not related to this bug, you may want to do that in a separate bug.
(Reporter)

Comment 1

5 years ago
Created attachment 632345 [details] [diff] [review]
correct paren placement in unit test
(Reporter)

Comment 2

5 years ago
Comment on attachment 632345 [details] [diff] [review]
correct paren placement in unit test

Relocated edit from bug patch 757828.
Fixed parens on one unit test line.
Attachment #632345 - Flags: review?(mh+mozilla)
Attachment #632345 - Flags: review?(mh+mozilla) → review+
https://hg.mozilla.org/mozilla-central/rev/10ad7878033a
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla16
You need to log in before you can comment on or make changes to this bug.