Closed
Bug 764037
Opened 14 years ago
Closed 14 years ago
makefiles: stray parenthesis character in the check_XinY.mk unit test
Categories
(Firefox Build System :: General, defect)
Firefox Build System
General
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla16
People
(Reporter: joey, Unassigned)
Details
Attachments
(1 file)
|
1.31 KB,
patch
|
glandium
:
review+
|
Details | Diff | Splinter Review |
::: config/makefiles/test/check_XinY.mk
@@ +23,5 @@
> # verify strcmp('clean')
> val := clean
> $(call errorifneq,$(zero),$(words $(call is_XinY,foo,$(val))))
> $(call errorifneq,$(one),$(words $(call is_XinY,clean,$(val))))
> +$(call errorifneq,$(one),$(words $(call is_XinY,clean%,$(val))))
Not related to this bug, you may want to do that in a separate bug.
|
Reporter | |
Comment 1•14 years ago
|
||
|
|
Reporter | |
Comment 2•14 years ago
|
||
Comment on attachment 632345 [details] [diff] [review]
correct paren placement in unit test
Relocated edit from bug patch 757828.
Fixed parens on one unit test line.
Attachment #632345 -
Flags: review?(mh+mozilla)
|
||
Updated•14 years ago
|
Attachment #632345 -
Flags: review?(mh+mozilla) → review+
|
||
Comment 3•14 years ago
|
||
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla16
|
||
Updated•8 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•