Last Comment Bug 764037 - makefiles: stray parenthesis character in the check_XinY.mk unit test
: makefiles: stray parenthesis character in the check_XinY.mk unit test
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: Build Config (show other bugs)
: unspecified
: All All
: -- normal (vote)
: mozilla16
Assigned To: Nobody; OK to take it and work on it
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-06-12 10:37 PDT by Joey Armstrong [:joey]
Modified: 2012-06-13 13:29 PDT (History)
1 user (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
correct paren placement in unit test (1.31 KB, patch)
2012-06-12 11:36 PDT, Joey Armstrong [:joey]
mh+mozilla: review+
Details | Diff | Splinter Review

Description Joey Armstrong [:joey] 2012-06-12 10:37:32 PDT
::: config/makefiles/test/check_XinY.mk
@@ +23,5 @@
>  # verify strcmp('clean')
>  val  := clean
>  $(call errorifneq,$(zero),$(words $(call is_XinY,foo,$(val))))
>  $(call errorifneq,$(one),$(words $(call is_XinY,clean,$(val))))
> +$(call errorifneq,$(one),$(words $(call is_XinY,clean%,$(val))))

Not related to this bug, you may want to do that in a separate bug.
Comment 1 Joey Armstrong [:joey] 2012-06-12 11:36:45 PDT
Created attachment 632345 [details] [diff] [review]
correct paren placement in unit test
Comment 2 Joey Armstrong [:joey] 2012-06-12 11:39:51 PDT
Comment on attachment 632345 [details] [diff] [review]
correct paren placement in unit test

Relocated edit from bug patch 757828.
Fixed parens on one unit test line.
Comment 3 Matt Brubeck (:mbrubeck) 2012-06-13 13:29:01 PDT
https://hg.mozilla.org/mozilla-central/rev/10ad7878033a

Note You need to log in before you can comment on or make changes to this bug.