Closed Bug 764051 Opened 12 years ago Closed 12 years ago

Crash when accessibility is disabled

Categories

(Firefox for Android Graveyard :: General, defect)

Product:
Firefox for Android Graveyard
Component:
General
Version:
15 Branch
Platform:
ARM
Android
Type:
defect
Priority:
Not set
Severity:
critical

Tracking

(firefox15 verified)

Status:
VERIFIED FIXED
Milestone:
Firefox 16
Tracking Flags:
Tracking Status
firefox15 --- verified

People

(Reporter: eeejay, Assigned: eeejay)

Details

(Keywords: crash, Whiteboard: [native-crash])

Crash Data

Attachments

(2 files)

Fix crasher when accessibility is turned off.
1.61 KB, patch
blassey
: review+
akeybl
: approval-mozilla-aurora+
Details | Diff | Splinter Review
Crash log
5.14 KB, text/x-log
Details 
When you disable Android accessibility and return to Firefox it will crash because it only checks system accessibility on startup and continues sending events unchecked.
Assignee: nobody → eitan
OS: Linux → Android
Hardware: x86_64 → ARM
Target Milestone: --- → Firefox 15
Version: Trunk → Firefox 15
For version 15, we should just catch exceptions. For future revisions I have a minor refactor that will check for accessibility on resume.
Attachment #632329 - Flags: review?(blassey.bugs)
(In reply to Eitan Isaacson [:eeejay] from comment #0)
> When you disable Android accessibility and return to Firefox it will crash
Can you provide a crash ID or a logcat to link this bug to Socorro?
Severity: normal → critical
Keywords: crash
Whiteboard: [native-crash]
Attached file Crash log — 

    
  
Crash Signature: [@ java.lang.IllegalStateException: Accessibility off. Did you forget to check that? at android.view.accessibility.AccessibilityManager.sendAccessibilityEvent(AccessibilityManager.java)]

        Attachment #632329 -
        Flags: review?(blassey.bugs) → review+

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/7ff8130ad590
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: Firefox 15 → Firefox 16

    
    

    
  
Comment on attachment 632329 [details] [diff] [review]
Fix crasher when accessibility is turned off.

[Approval Request Comment]
User impact if declined: Crash when user disables system accessibility.
Testing completed (on m-c, etc.): Yes.
Risk to taking this patch (and alternatives if risky): Should be no risk, it is a simple catch statement.
String or UUID changes made by this patch: None.

        Attachment #632329 -
        Flags: approval-mozilla-aurora?

    
  

        Attachment #632329 -
        Flags: approval-mozilla-aurora? → approval-mozilla-aurora+

    
    

    
  
Firefox no longer crashes when returning to the app after disabling accessibility. Used TalkBack to test.

Verified on:
Nightly 16.0a1 2012-07-10/Aurora 15.0a2 2012-07-10
Samsung Google Nexus
Android 4.0.2
Status: RESOLVED → VERIFIED

          status-firefox15:
          fixed → verified
Product: Firefox for Android → Firefox for Android Graveyard

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: