764104 - Compilation fails if C++ keyword used in WebIDL enum.

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[William Chen [:wchen]]

WebIDL enum containing a C++ keyword will generate C++ a enum that contain the keyword, causing compilation to fail.

Example:

enum NotificationPermission {
  "default",
  "denied",
  "granted"
};

taken from (http://dvcs.w3.org/hg/notifications/raw-file/tip/Overview.html#api) will generate:

enum valuelist {
  default,
  denied,
  granted
};

The enum above will fail to compile due to the "default" keyword (at least in clang).

Comment 1

[Boris Zbarsky [:bzbarsky]]

Yeah, this is a bit of a PITA.  

One option is to upcase the first character of each enum value.  So we would have:

  enum valuelist {
    Default,
    Denied,
    Granted
  };

Another is to add more special cases to getEnumValueName (there's already a special case for "", but we could add one for "default").

Comment 2

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

I vote for upper case.

Comment 3

[Boris Zbarsky [:bzbarsky]]

Attachment: Avoid collisions with C++ reserved words by using initial-caps for WebIDL enum values.

Comment 4

[Boris Zbarsky [:bzbarsky]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/0fd65c8f53c8

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/0fd65c8f53c8