Last Comment Bug 764130 - Don't crash if NULL is passed to DOMRequestService methods
: Don't crash if NULL is passed to DOMRequestService methods
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: DOM (show other bugs)
: Trunk
: x86_64 Linux
: -- normal (vote)
: mozilla16
Assigned To: Justin Lebar (not reading bugmail)
:
Mentors:
Depends on:
Blocks: 741755
  Show dependency treegraph
 
Reported: 2012-06-12 13:20 PDT by Justin Lebar (not reading bugmail)
Modified: 2012-06-14 02:46 PDT (History)
3 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Patch, v1 (1.13 KB, patch)
2012-06-12 15:03 PDT, Justin Lebar (not reading bugmail)
bugs: review+
Details | Diff | Splinter Review

Description Justin Lebar (not reading bugmail) 2012-06-12 13:20:30 PDT
If I pass NULL to a DOMRquestService method -- even from JS -- the whole process crashes.  That's a bit much...

Patch in a moment.
Comment 1 Justin Lebar (not reading bugmail) 2012-06-12 15:03:32 PDT
Created attachment 632431 [details] [diff] [review]
Patch, v1
Comment 2 Justin Lebar (not reading bugmail) 2012-06-12 18:08:35 PDT
Comment on attachment 632431 [details] [diff] [review]
Patch, v1

Actually, Jonas is on vacation.  Olli?
Comment 3 Justin Lebar (not reading bugmail) 2012-06-13 14:29:48 PDT
https://hg.mozilla.org/integration/mozilla-inbound/rev/cadfa20eb77e
Comment 4 Ed Morley [:emorley] 2012-06-14 02:46:15 PDT
https://hg.mozilla.org/mozilla-central/rev/cadfa20eb77e

Note You need to log in before you can comment on or make changes to this bug.