Last Comment Bug 764207 - Tryserver pushes should output TBPL link for the push
: Tryserver pushes should output TBPL link for the push
Product: Developer Services
Classification: Other
Component: Mercurial: (show other bugs)
: other
: All All
-- enhancement
: ---
Assigned To: Graeme McCutcheon [:graememcc]
Depends on: 751867
  Show dependency treegraph
Reported: 2012-06-12 16:15 PDT by Justin Dolske [:Dolske]
Modified: 2014-10-02 07:01 PDT (History)
6 users (show)
See Also:
QA Whiteboard:
Iteration: ---
Points: ---

v1 (989 bytes, patch)
2012-06-13 07:41 PDT, Graeme McCutcheon [:graememcc]
ted: review+
Details | Diff | Splinter Review

Description User image Justin Dolske [:Dolske] 2012-06-12 16:15:48 PDT
+++ This bug was initially created as a clone of Bug #663585 +++

"It'd be handy if, when pushing, the hg changeset URL were printed, since often you want to paste that URL into a bug."

It would also be REALLY handy if a Tryserver push spat out a TBPL link for the push, since on occasion people will look at that URL to see results. :)

Presumably all the info should be at-hand...

$ hg log -l 1
changeset:   96464:1b3e7e9f46a5

TBPL link:

I suppose there's no reason to limit it exclusively to Try, but that would be the most useful to me.
Comment 1 User image Dirkjan Ochtman (:djc) 2012-06-13 00:28:20 PDT
Instead of having a push print out the changeset URL, have it post the changeset URL to the bug mentioned in the commit message?
Comment 2 User image Cameron McCormack (:heycam) (away 25 Feb–5 Mar) 2012-06-13 00:29:47 PDT
There are plenty of times I push to try without it being something I want reported in the bug, so I'd rather it be just printed out after pushing.
Comment 3 User image Dirkjan Ochtman (:djc) 2012-06-13 01:43:51 PDT
Sure. You could also have it distinguish between pushing to try and elsewhere.
Comment 4 User image Graeme McCutcheon [:graememcc] 2012-06-13 07:41:46 PDT
Created attachment 632690 [details] [diff] [review]

Taking the simple approach here.

I guess I'd be slightly cautious about talking to something external in the hook. I believe the hook for caused a few intermittent tree closures before being disabled.
Comment 5 User image Ted Mielczarek [:ted.mielczarek] 2012-06-13 09:49:53 PDT
Comment on attachment 632690 [details] [diff] [review]

Review of attachment 632690 [details] [diff] [review]:

Fine with me. In the future, feel free to push changes here without review if you'd like. It's your code. :)
Comment 6 User image Graeme McCutcheon [:graememcc] 2012-06-13 09:54:20 PDT
Comment 7 User image Justin Dolske [:Dolske] 2012-06-17 00:44:06 PDT

Note You need to log in before you can comment on or make changes to this bug.