764318 - [responsive mode] use this.tab.selected

Status: RESOLVED FIXED

(DevTools :: General, defect)

Comment 1

[Paul Rouget [:paul]]

Attachment: patch v1

Comment 2

[Paul Rouget [:paul]]

Dao, I am also interested to know if this is the best way to be notified if a tab has been selected / hidden.

Comment 3

[Dão Gottwald [:dao]]

(In reply to Paul Rouget [:paul] from comment #2)
> Dao, I am also interested to know if this is the best way to be notified if
> a tab has been selected / hidden.

Normally you'd use a TabSelect listener on gBrowser.tabContainer.

Comment 4

[Paul Rouget [:paul]]

Attachment: patch v1.1

Comment 5

[Paul Rouget [:paul]]

Comment on attachment 632635 [details] [diff] [review]
patch v1.1

Thanks.

Comment 6

[Dão Gottwald [:dao]]

When does this event listener get removed?

Comment 7

[Paul Rouget [:paul]]

Attachment: patch v1.2

erf

Comment 8

[Paul Rouget [:paul]]

Actually, this won't work because we uncheck the buttons if another tab is selected.
But we don't know if the next tab is not in the responsive mode.

Comment 9

[Paul Rouget [:paul]]

Attachment: patch v1.3

Uncheck only if the new selected tab is not in responsive mode

Comment 10

[Dão Gottwald [:dao]]

Comment on attachment 632643 [details] [diff] [review]
patch v1.3

Please file a bug on renaming tab.responsiveUI to tab.__responsiveUI, since it's no property managed by tabbrowser.xml but entirely external.

Comment 11

[Paul Rouget [:paul]]

Bug 766512 - Rename tab.responsiveUI to tab.__responsiveUI

Comment 12

[Panos Astithas (he/him) [:past] (please ni?)]

https://hg.mozilla.org/integration/fx-team/rev/32975daf82d7

Comment 13

[Panos Astithas (he/him) [:past] (please ni?)]

https://hg.mozilla.org/mozilla-central/rev/32975daf82d7