[responsive mode] use this.tab.selected

RESOLVED FIXED in Firefox 16

Status

()

Firefox
Developer Tools
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: paul, Assigned: paul)

Tracking

Trunk
Firefox 16
x86
All
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 3 obsolete attachments)

Comment hidden (empty)
(Assignee)

Comment 1

5 years ago
Created attachment 632623 [details] [diff] [review]
patch v1
(Assignee)

Updated

5 years ago
Attachment #632623 - Flags: review?(dao)
(Assignee)

Comment 2

5 years ago
Dao, I am also interested to know if this is the best way to be notified if a tab has been selected / hidden.
(In reply to Paul Rouget [:paul] from comment #2)
> Dao, I am also interested to know if this is the best way to be notified if
> a tab has been selected / hidden.

Normally you'd use a TabSelect listener on gBrowser.tabContainer.
(Assignee)

Comment 4

5 years ago
Created attachment 632635 [details] [diff] [review]
patch v1.1
(Assignee)

Comment 5

5 years ago
Comment on attachment 632635 [details] [diff] [review]
patch v1.1

Thanks.
Attachment #632635 - Flags: review?(dao)
(Assignee)

Updated

5 years ago
Attachment #632623 - Attachment is obsolete: true
Attachment #632623 - Flags: review?(dao)
When does this event listener get removed?
(Assignee)

Comment 7

5 years ago
Created attachment 632637 [details] [diff] [review]
patch v1.2

erf
(Assignee)

Updated

5 years ago
Attachment #632635 - Attachment is obsolete: true
Attachment #632635 - Flags: review?(dao)
(Assignee)

Updated

5 years ago
Attachment #632637 - Flags: review?(dao)

Updated

5 years ago
Attachment #632637 - Flags: review?(dao) → review+
(Assignee)

Updated

5 years ago
Whiteboard: [land-in-fx-team]
(Assignee)

Updated

5 years ago
Whiteboard: [land-in-fx-team]
(Assignee)

Comment 8

5 years ago
Actually, this won't work because we uncheck the buttons if another tab is selected.
But we don't know if the next tab is not in the responsive mode.
(Assignee)

Comment 9

5 years ago
Created attachment 632643 [details] [diff] [review]
patch v1.3

Uncheck only if the new selected tab is not in responsive mode
(Assignee)

Updated

5 years ago
Attachment #632637 - Attachment is obsolete: true
(Assignee)

Updated

5 years ago
Attachment #632643 - Flags: review?(dao)
Comment on attachment 632643 [details] [diff] [review]
patch v1.3

Please file a bug on renaming tab.responsiveUI to tab.__responsiveUI, since it's no property managed by tabbrowser.xml but entirely external.
Attachment #632643 - Flags: review?(dao) → review+
(Assignee)

Comment 11

5 years ago
Bug 766512 - Rename tab.responsiveUI to tab.__responsiveUI
Whiteboard: [land-in-fx-team]
https://hg.mozilla.org/integration/fx-team/rev/32975daf82d7
Assignee: nobody → paul
Status: NEW → ASSIGNED
Whiteboard: [land-in-fx-team] → [fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/32975daf82d7
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 16
You need to log in before you can comment on or make changes to this bug.