764324 - Fix breakpoint handling for Fennec and B2G browser actors

Status: RESOLVED FIXED

(DevTools :: Debugger, defect, P2)

Description

[Panos Astithas (he/him) [:past] (please ni?)]

Bug 737808 changed the way breakpoints are handled in the debugger server, but only desktop Firefox was updated. Fennec and B2G need the same changes in order for breakpoint setting to work. Bug 751226 will make sure we never get into this situation again, but it may be a few more weeks until I can get to it.

Comment 1

[Panos Astithas (he/him) [:past] (please ni?)]

Attachment: Combined patch

Simple fix. B2G needed an additional fix for including the XPCOM helper in the packaging, in order for the debugger to work in a real device (as opposed to desktop b2g).

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 632629 [details] [diff] [review]
Combined patch

r+ on the fennec parts

Comment 3

[Panos Astithas (he/him) [:past] (please ni?)]

https://hg.mozilla.org/integration/fx-team/rev/864c3502d038

Comment 4

[Tim Taubert [:ttaubert] (inactive)]

https://hg.mozilla.org/mozilla-central/rev/864c3502d038

Comment 5

[Panos Astithas (he/him) [:past] (please ni?)]

Comment on attachment 632629 [details] [diff] [review]
Combined patch

[Approval Request Comment]
Bug caused by (feature/regressing bug #): New feature
User impact if declined: Fennec 15 will have broken breakpoint support in the debugger
Testing completed (on m-c, etc.): On m-c
Risk to taking this patch (and alternatives if risky): this is a pretty straight-forward patch that only adds two new single-line methods. There is the same change for b2g as well which does not impact Fennec in any way, which could be left out if people are worried for some reason.
String or UUID changes made by this patch: none

Comment 6

[Alex Keybl [:akeybl]]

Comment on attachment 632629 [details] [diff] [review]
Combined patch

[Triage Comment]
Fix for a new feature, risk to b2g but we're not shipping b2g off of 15 so go for it.

Comment 7

[Panos Astithas (he/him) [:past] (please ni?)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/d41b2d8f0630