Last Comment Bug 764420 - Incorrect type-check for ArrayBufferView arguments in generated code
: Incorrect type-check for ArrayBufferView arguments in generated code
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: DOM (show other bugs)
: unspecified
: x86 Mac OS X
: -- normal (vote)
: mozilla16
Assigned To: Boris Zbarsky [:bz] (Out June 25-July 6)
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-06-13 08:43 PDT by Boris Zbarsky [:bz] (Out June 25-July 6)
Modified: 2012-06-20 02:21 PDT (History)
1 user (show)
bzbarsky: in‑testsuite?
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Fix ArrayBufferView unwrapping to allow DataViews. (1.26 KB, patch)
2012-06-13 08:45 PDT, Boris Zbarsky [:bz] (Out June 25-July 6)
khuey: review+
Details | Diff | Review

Description Boris Zbarsky [:bz] (Out June 25-July 6) 2012-06-13 08:43:59 PDT
We're checking JS_IsTypedArrayObject, but we should be checking JS_IsArrayBufferViewObject.
Comment 1 Boris Zbarsky [:bz] (Out June 25-July 6) 2012-06-13 08:45:11 PDT
Created attachment 632716 [details] [diff] [review]
Fix ArrayBufferView unwrapping to allow DataViews.
Comment 2 Boris Zbarsky [:bz] (Out June 25-July 6) 2012-06-19 09:12:50 PDT
https://hg.mozilla.org/integration/mozilla-inbound/rev/53dccafefad6
Comment 3 Ed Morley [:emorley] 2012-06-20 02:21:51 PDT
https://hg.mozilla.org/mozilla-central/rev/53dccafefad6

Note You need to log in before you can comment on or make changes to this bug.