Closed Bug 764474 Opened 10 years ago Closed 10 years ago

[inspector] arrow keys are creating problems

Categories

(DevTools :: Inspector, defect)

x86
All
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 16

People

(Reporter: paul, Unassigned)

Details

Attachments

(1 file)

The highlighter highlights other elements when we use the arrow keys.
But we don't stop the event.

If the web site uses the arrows keys to do "things", it's just a complete mess.
Use right/left with this website for example: http://www.tibco.com/
Or try to move the cursor in jsbin.com.

I think we should just not highlight other nodes when arrow keys are pressed.
We should only use the arrow keys when the breadcrumbs are focused.
Attached patch v1Splinter Review
Attachment #638660 - Flags: review?(dcamp)
Attachment #638660 - Flags: review?(dcamp) → review?(fayearthur)
Comment on attachment 638660 [details] [diff] [review]
v1

Really into this patch, much better behavior now. I guess you could change that comment since it's a one-item list now, but not necessary at all. Awesome!
Attachment #638660 - Flags: review?(fayearthur) → review+
Whiteboard: [land-in-fx-team]
https://hg.mozilla.org/integration/fx-team/rev/7ca8c657adae
Whiteboard: [land-in-fx-team] → [fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/7ca8c657adae
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 16
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.