Last Comment Bug 764508 - "Assertion failure: !p.value().isHeader()" with redundant default params, "let"
: "Assertion failure: !p.value().isHeader()" with redundant default params, "let"
Status: RESOLVED FIXED
[js:t]
: assertion, testcase
Product: Core
Classification: Components
Component: JavaScript Engine (show other bugs)
: Trunk
: x86_64 Mac OS X
: -- critical (vote)
: mozilla16
Assigned To: :Benjamin Peterson
:
:
Mentors:
Depends on:
Blocks: jsfunfuzz harmony:defaults
  Show dependency treegraph
 
Reported: 2012-06-13 11:46 PDT by Jesse Ruderman
Modified: 2012-06-21 04:03 PDT (History)
5 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
fix (1.28 KB, patch)
2012-06-13 14:42 PDT, :Benjamin Peterson
jorendorff: review+
Details | Diff | Splinter Review

Description Jesse Ruderman 2012-06-13 11:46:55 PDT
function f(x = let (x) 1, x = 4) { }

Assertion failure: !p.value().isHeader(), at js/src/frontend/ParseMaps-inl.h:85

The first bad revision is:
changeset:   699a613bf616
user:        Benjamin Peterson
date:        Sat May 26 09:33:53 2012 -0400
summary:     Bug 757676 - Implement JS default parameters. r=jorendorff
Comment 1 :Benjamin Peterson 2012-06-13 14:42:55 PDT
Created attachment 632889 [details] [diff] [review]
fix
Comment 2 Jason Orendorff [:jorendorff] 2012-06-20 16:19:58 PDT
Comment on attachment 632889 [details] [diff] [review]
fix

Nice fix; totally gross bug.

Wish I had time to clean this code up. It could be better.
Comment 3 Gary Kwong [:gkw] [:nth10sd] 2012-06-20 16:35:20 PDT
http://hg.mozilla.org/integration/mozilla-inbound/rev/866273a96085
Comment 4 Ed Morley [:emorley] 2012-06-21 04:03:49 PDT
https://hg.mozilla.org/mozilla-central/rev/866273a96085

Note You need to log in before you can comment on or make changes to this bug.