"Assertion failure: !p.value().isHeader()" with redundant default params, "let"

RESOLVED FIXED in mozilla16

Status

()

Core
JavaScript Engine
--
critical
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: Jesse Ruderman, Assigned: Benjamin)

Tracking

(Blocks: 1 bug, {assertion, testcase})

Trunk
mozilla16
x86_64
Mac OS X
assertion, testcase
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [js:t])

Attachments

(1 attachment)

(Reporter)

Description

5 years ago
function f(x = let (x) 1, x = 4) { }

Assertion failure: !p.value().isHeader(), at js/src/frontend/ParseMaps-inl.h:85

The first bad revision is:
changeset:   699a613bf616
user:        Benjamin Peterson
date:        Sat May 26 09:33:53 2012 -0400
summary:     Bug 757676 - Implement JS default parameters. r=jorendorff
(Assignee)

Comment 1

5 years ago
Created attachment 632889 [details] [diff] [review]
fix
Assignee: general → bpeterson
Attachment #632889 - Flags: review?(jorendorff)
Whiteboard: [js:t]
Comment on attachment 632889 [details] [diff] [review]
fix

Nice fix; totally gross bug.

Wish I had time to clean this code up. It could be better.
Attachment #632889 - Flags: review?(jorendorff) → review+
(Assignee)

Updated

5 years ago
Keywords: checkin-needed
http://hg.mozilla.org/integration/mozilla-inbound/rev/866273a96085
Keywords: checkin-needed
Target Milestone: --- → mozilla16

Comment 4

5 years ago
https://hg.mozilla.org/mozilla-central/rev/866273a96085
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.