Closed
Bug 764545
Opened 13 years ago
Closed 13 years ago
WebConsole default position should be "below"
Categories
(DevTools :: Console, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 16
People
(Reporter: paul, Assigned: sankha)
References
Details
(Whiteboard: [fixed-in-fx-team][good first bug][mentor=msucan][lang=js])
Attachments
(1 file, 1 obsolete file)
|
5.65 KB,
patch
|
msucan
:
review+
|
Details | Diff | Splinter Review |
When we will enable the global developer toolbar, we want the console to show up above the toolbar.
|
||
Updated•13 years ago
|
Component: Developer Tools → Developer Tools: Console
QA Contact: developer.tools → developer.tools.console
|
||
Updated•13 years ago
|
Whiteboard: [good first bug][mentor=msucan][lang=js]
|
||
Comment 1•13 years ago
|
||
Link to relevant source?
|
Reporter | |
Comment 2•13 years ago
|
||
I think we only need to update this value:
http://mxr.mozilla.org/mozilla-central/source/browser/app/profile/firefox.js#1097
|
Assignee | |
Comment 3•13 years ago
|
||
I have a patch ready for this bug. But who should I ask for review when posting the patch?
|
|
||
Comment 4•13 years ago
|
||
Sankha: you can ask me for review. Thanks for your time working on this bug!
Assignee: nobody → sankha93
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 5•13 years ago
|
||
Attachment #636628 -
Flags: review?(mihai.sucan)
|
|
||
Comment 6•13 years ago
|
||
Comment on attachment 636628 [details] [diff] [review]
Patch to the bug; needs review
Thanks for your patch! It applies cleanly and it does what we want.
However, we have a couple of tests that fail now because they expect the other position. Can you please run the tests and fix the failures?
See https://developer.mozilla.org/en/Browser_chrome_tests
The Web Console tests are located in browser/devtools/webconsole/test. Please let me know if I can help.
Thanks!
Attachment #636628 -
Flags: review?(mihai.sucan)
|
|
Assignee | |
Comment 7•13 years ago
|
||
Attachment #636628 -
Attachment is obsolete: true
Attachment #637013 -
Flags: review?(mihai.sucan)
|
|
||
Comment 8•13 years ago
|
||
Comment on attachment 637013 [details] [diff] [review]
[in-fx-team] Patch now passes all webconsole tests
Thank you for a patch well done!
I pushed the patch to the try servers to make sure all tests pass on all systems, not just mine and yours.
https://tbpl.mozilla.org/?tree=Try&rev=805149a6e4b7
Once results are positive, we will push your patch into Firefox. Thanks!
Attachment #637013 -
Flags: review?(mihai.sucan) → review+
|
|
||
Updated•13 years ago
|
Whiteboard: [good first bug][mentor=msucan][lang=js] → [land-in-fx-team][good first bug][mentor=msucan][lang=js]
|
|
||
Comment 9•13 years ago
|
||
Comment on attachment 637013 [details] [diff] [review]
[in-fx-team] Patch now passes all webconsole tests
Landed:
https://hg.mozilla.org/integration/fx-team/rev/afc76272017b
Thank you for your contribution Sankha!
Attachment #637013 -
Attachment description: Patch now passes all webconsole tests → [in-fx-team] Patch now passes all webconsole tests
|
|
||
Updated•13 years ago
|
Whiteboard: [land-in-fx-team][good first bug][mentor=msucan][lang=js] → [fixed-in-fx-team][good first bug][mentor=msucan][lang=js]
|
||
Comment 10•13 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 16
|
||
Updated•7 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•