Created attachment 31294 [details] [diff] [review] use nsIPrintOptions silent attribute in the print api
status to new and adding keywords
Status: UNCONFIRMED → NEW
Ever confirmed: true
Keywords: patch, review
Correction: Changing QA contact for the Embed API bugs to David Epstein.
QA Contact: mdunn → depstein
Reassigning to Don. Don, can you verify the way silent printing should work? Personally I think that in silent mode or when there is no print listener (which could mean the same thing) that the Print command should only return once printing has completed. This prevents crashes when the content viewer is destroyed mid-print by the docshell when the user browses to another page.
Assignee: adamlock → dcone
sr=attinasi. Have we verified that this takes care of the concern that Adam Lock mentioned about crashing during printing when a newq page is navigated to?
Checked in fix. The issue brought up by Adam is actually another bug I am working on.
Status: NEW → RESOLVED
Last Resolved: 17 years ago
Resolution: --- → FIXED
now calles GetPrintSilent() and passes silent var to Print().
Status: RESOLVED → VERIFIED
Checked into the .92 branch.
The bug is back, silent is ignored. In nsWebBrowser::DoPrintOrPrintPreview rv = contentViewerFile->Print(PR_FALSE, aThePrintSettings, aProgressListener); The patch is trivial and similar to first one. Let me know if I should submit and updated version of it. This is pretty critical for galeon, it would be good if it could be fixed for 0.9.8 release.
Status: VERIFIED → REOPENED
Resolution: FIXED → ---
Reassigning to Rod.
Assignee: dcone → rods
Status: REOPENED → NEW
Created attachment 66315 [details] [diff] [review] patch that passes the silent flag properly This patch gets the silent value from the print options and passes it on properly.
I've tested this patch with galeon and mozilla and it seems to do the right thing.
Whiteboard: has patch → [driver:blizzard] has patch
This is no longer an issue for the 094 branch. Removing topembed keyword.
r=rods I'll check this in to the trunk and the 0.9.8 branch But I have a large patch coming that reworks the APIS and the silent arg goes away along with the confusion.
Status: NEW → ASSIGNED
a=blizzard on behalf of drivers for 0.9.8
checked in on 0.9.8 brnach and trunk - fixed
Status: ASSIGNED → RESOLVED
Last Resolved: 17 years ago → 16 years ago
Resolution: --- → FIXED
I didn't see this patch checkin in the trunk (nsWebBrowser.cpp). Mozilla trunk build 0.9.8 Gecko 20020209.
You need to log in before you can comment on or make changes to this bug.