76456 - [Patch] nsIWebBrowserPrint must allow to do a silent print

Status: RESOLVED FIXED

(Core Graveyard :: Embedding: APIs, defect)

Description

[Marco Pesenti Gritti]

Comment 1

[Marco Pesenti Gritti]

Attachment: use nsIPrintOptions silent attribute in the print api

Comment 2

[Boris Zbarsky [:bzbarsky]]

status to new and adding keywords

Comment 3

[Michael Dunn]

Correction: Changing QA contact for the Embed API bugs to David Epstein.

Comment 4

[Adam Lock]

Reassigning to Don.

Don, can you verify the way silent printing should work?

Personally I think that in silent mode or when there is no print listener (which 
could mean the same thing) that the Print command should only return once 
printing has completed. This prevents crashes when the content viewer is 
destroyed mid-print by the docshell when the user browses to another page.

Comment 5

[dcone (gone)]

r=dcone

Comment 6

[Marc Attinasi]

sr=attinasi. Have we verified that this takes care of the concern that Adam Lock
mentioned about crashing during printing when a newq page is navigated to?

Comment 7

[dcone (gone)]

Checked in fix.  The issue brought up by Adam is actually another bug I am 
working on.

Comment 8

[David Epstein]

now calles GetPrintSilent() and passes silent var to Print(). 

Comment 9

[dcone (gone)]

Checked into the .92 branch.

Comment 10

[Marco Pesenti Gritti]

The bug is back, silent is ignored.

In nsWebBrowser::DoPrintOrPrintPreview
rv = contentViewerFile->Print(PR_FALSE, aThePrintSettings, aProgressListener);

The patch is trivial and similar to first one. Let me know if I should submit
and updated version of it.
This is pretty critical for galeon, it would be good if it could be fixed for
0.9.8 release.

Comment 11

[Kevin McCluskey (gone)]

Reassigning to Rod.

Comment 12

[Christopher Blizzard (:blizzard)]

Attachment: patch that passes the silent flag properly

This patch gets the silent value from the print options and passes it on
properly.

Comment 13

[Christopher Blizzard (:blizzard)]

I've tested this patch with galeon and mozilla and it seems to do the right thing.

Comment 14

[Kevin McCluskey (gone)]

This is no longer an issue for the 094 branch. Removing topembed keyword.

Comment 15

[rods (gone)]

r=rods 
I'll check this in to the trunk and the 0.9.8 branch

But I have a large patch coming that reworks the APIS and the silent arg goes
away along with the confusion.

Comment 16

[David Hyatt]

sr=hyatt

Comment 17

[Christopher Blizzard (:blizzard)]

a=blizzard on behalf of drivers for 0.9.8

Comment 18

[rods (gone)]

checked in on 0.9.8 brnach and trunk - fixed

Comment 19

[David Epstein]

I didn't see this patch checkin in the trunk (nsWebBrowser.cpp). Mozilla trunk
build 0.9.8 Gecko 20020209.