The default bug view has changed. See this FAQ.

PromptService.Show should be PromptService.show

RESOLVED FIXED in Firefox 15

Status

()

Firefox for Android
General
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: kats, Assigned: kats)

Tracking

Trunk
Firefox 16
All
Android
Points:
---

Firefox Tracking Flags

(firefox15 fixed, firefox16 fixed)

Details

Attachments

(1 attachment)

Created attachment 632879 [details] [diff] [review]
Patch

Java naming convention consistency.
Attachment #632879 - Flags: review?(margaret.leibovic)

Comment 1

5 years ago
Comment on attachment 632879 [details] [diff] [review]
Patch

Review of attachment 632879 [details] [diff] [review]:
-----------------------------------------------------------------

::: mobile/android/base/PromptService.java
@@ +381,5 @@
>          boolean multiple = false;
>          try {
>              multiple = geckoObject.getBoolean("multiple");
>          } catch(Exception ex) { }
> +        this.show(title, text, promptbuttons, menuitems, multiple);

As per Java conventions, we can get rid of the |this.| here.
Attachment #632879 - Flags: review?(margaret.leibovic) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/bf12b1b12b2d
status-firefox16: --- → fixed
Target Milestone: --- → Firefox 16
https://hg.mozilla.org/mozilla-central/rev/bf12b1b12b2d
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Landed in http://hg.mozilla.org/releases/mozilla-beta/rev/b04c6364ebf6
status-firefox15: --- → fixed
You need to log in before you can comment on or make changes to this bug.