Closed
Bug 764579
Opened 13 years ago
Closed 13 years ago
PromptService.Show should be PromptService.show
Categories
(Firefox for Android Graveyard :: General, defect)
Tracking
(firefox15 fixed, firefox16 fixed)
RESOLVED
FIXED
Firefox 16
People
(Reporter: kats, Assigned: kats)
Details
Attachments
(1 file)
|
2.92 KB,
patch
|
Margaret
:
review+
|
Details | Diff | Splinter Review |
Java naming convention consistency.
Attachment #632879 -
Flags: review?(margaret.leibovic)
|
||
Comment 1•13 years ago
|
||
Comment on attachment 632879 [details] [diff] [review]
Patch
Review of attachment 632879 [details] [diff] [review]:
-----------------------------------------------------------------
::: mobile/android/base/PromptService.java
@@ +381,5 @@
> boolean multiple = false;
> try {
> multiple = geckoObject.getBoolean("multiple");
> } catch(Exception ex) { }
> + this.show(title, text, promptbuttons, menuitems, multiple);
As per Java conventions, we can get rid of the |this.| here.
Attachment #632879 -
Flags: review?(margaret.leibovic) → review+
|
Assignee | |
Comment 2•13 years ago
|
||
status-firefox16:
--- → fixed
Target Milestone: --- → Firefox 16
|
||
Comment 3•13 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
|
||
Comment 4•13 years ago
|
||
status-firefox15:
--- → fixed
|
||
Updated•5 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•