764579 - PromptService.Show should be PromptService.show

Status: RESOLVED FIXED

Description

[Kartikaya Gupta (email:[e-mail])]

Created attachment 632879 [details] [diff] [review]
Patch

Java naming convention consistency.

Comment 1

[:Margaret Leibovic]

Comment on attachment 632879 [details] [diff] [review]
Patch

Review of attachment 632879 [details] [diff] [review]:
-----------------------------------------------------------------

::: mobile/android/base/PromptService.java
@@ +381,5 @@
>          boolean multiple = false;
>          try {
>              multiple = geckoObject.getBoolean("multiple");
>          } catch(Exception ex) { }
> +        this.show(title, text, promptbuttons, menuitems, multiple);

As per Java conventions, we can get rid of the |this.| here.

Comment 2

[Kartikaya Gupta (email:[e-mail])]

https://hg.mozilla.org/integration/mozilla-inbound/rev/bf12b1b12b2d

Comment 3

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/bf12b1b12b2d

Comment 4

[Brian Nicholson (:bnicholson)]

Landed in http://hg.mozilla.org/releases/mozilla-beta/rev/b04c6364ebf6