Closed
Bug 764638
Opened 13 years ago
Closed 12 years ago
Find in page can better use LinearLayout
Categories
(Firefox for Android Graveyard :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 23
People
(Reporter: sriram, Assigned: sriram)
References
Details
Attachments
(1 file)
|
4.87 KB,
patch
|
Margaret
:
review+
|
Details | Diff | Splinter Review |
It's better to use LinearLayout for horizontal layouts. RelativeLayout makes things more complex.
|
Assignee | |
Comment 1•13 years ago
|
||
Sorry. This was more of an OCD for me. ;)
Assignee: nobody → sriram
Attachment #632946 -
Flags: review?(margaret.leibovic)
|
||
Comment 2•13 years ago
|
||
Comment on attachment 632946 [details] [diff] [review]
Patch
Nice :) I just stuck with the first thing that worked like I wanted it to, but I agree this is better. Also, good call to move the background out to styles.xml.
Attachment #632946 -
Flags: review?(margaret.leibovic) → review+
|
|
Assignee | |
Comment 3•13 years ago
|
||
|
||
Comment 4•13 years ago
|
||
Sorry, I backed this out because something in the push caused various failures in mochitest-1, 2, 3, and 8.
https://hg.mozilla.org/integration/mozilla-inbound/rev/c820098cb62d
|
|
Assignee | |
Comment 5•12 years ago
|
||
Pushed after a long time: https://hg.mozilla.org/integration/mozilla-inbound/rev/1fa259b3c08c
|
||
Comment 6•12 years ago
|
||
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 23
|
||
Updated•4 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•