Implement ContactChangeEvent in C++

RESOLVED FIXED in mozilla16

Status

()

Core
DOM: Device Interfaces
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: gwagner, Assigned: gwagner)

Tracking

(Depends on: 1 bug)

unspecified
mozilla16
x86
Mac OS X
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Comment hidden (empty)
(Assignee)

Comment 1

5 years ago
Created attachment 632991 [details] [diff] [review]
patch

Followed the settings implementation.
Assignee: nobody → anygregor
Attachment #632991 - Flags: review?(bugs)

Updated

5 years ago
Summary: Implement oncontactschange event in C++ → Implement ContactChangeEvent event in C++

Updated

5 years ago
Summary: Implement ContactChangeEvent event in C++ → Implement ContactChangeEvent in C++

Comment 2

5 years ago
Comment on attachment 632991 [details] [diff] [review]
patch

>--- /dev/null	Thu Jan 01 00:00:00 1970 +0000
>+++ b/content/events/src/nsDOMContactChangeEvent.cpp	Wed Jun 13 18:51:19 2012 -0700
>@@ -0,0 +1,67 @@
>+/* -*- Mode: C++; tab-width: 2; indent-tabs-mode: nil; c-basic-offset: 2 -*- */
>+/* This Source Code Form is subject to the terms of the Mozilla Public
>+ * License, v. 2.0. If a copy of the MPL was not distributed with this file,
>+ * You can obtain one at http://mozilla.org/MPL/2.0/. */
>+
>+#include "nsDOMContactChangeEvent.h"
>+#include "nsContentUtils.h"
>+#include "DictionaryHelpers.h"
>+
>+DOMCI_DATA(MozContactChangeEvent, nsDOMMozContactChangeEvent)
>+
>+NS_INTERFACE_MAP_BEGIN(nsDOMMozContactChangeEvent)
>+  NS_INTERFACE_MAP_ENTRY(nsIDOMMozContactChangeEvent)
>+  NS_DOM_INTERFACE_MAP_ENTRY_CLASSINFO(MozContactChangeEvent)
>+NS_INTERFACE_MAP_END_INHERITING(nsDOMEvent)
>+
>+NS_IMPL_ADDREF_INHERITED(nsDOMMozContactChangeEvent, nsDOMEvent)
>+NS_IMPL_RELEASE_INHERITED(nsDOMMozContactChangeEvent, nsDOMEvent)
>+
>+NS_IMETHODIMP
>+nsDOMMozContactChangeEvent::GetContactID(nsAString & aContactID)
nsAString& aContactID


>+nsDOMMozContactChangeEvent::GetReason(nsAString & aReason)
nsAString& aReason



>+nsDOMMozContactChangeEvent::InitMozContactChangeEvent(const nsAString& aType,
>+                                                      bool aCanBubble,
>+                                                      bool aCancelable,
>+                                                      const nsAString &aContactID,
>+                                                      const nsAString &aReason)
const nsAString& aContactID,
const nsAString& aReason



>+class nsDOMMozContactChangeEvent : public nsDOMEvent,
>+                                   public nsIDOMMozContactChangeEvent
>+{
>+public:
>+  nsDOMMozContactChangeEvent(nsPresContext* aPresContext, nsEvent* aEvent)
>+    : nsDOMEvent(aPresContext, aEvent) {}
>+                     
>+  NS_DECL_ISUPPORTS_INHERITED
>+  NS_DECL_CYCLE_COLLECTION_CLASS_INHERITED(nsDOMMozContactChangeEvent, nsDOMEvent)
There shouldn't be need for this. You're not adding anything to the cycle collection.



> 
> [scriptable, builtinclass, uuid(50e09826-d08e-4a75-8efb-5dfb2aa70874)]
>-interface mozIDOMContactEvent : nsIDOMEvent
>+interface nsIDOMMozContactChangeEvent : nsIDOMEvent
update the uuid
Attachment #632991 - Flags: review?(bugs) → review+
(Assignee)

Comment 3

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/5a0a22492be2
Depends on: 765136

Comment 4

5 years ago
Android M3 is pretty much perma-orange due to bug 765136.
Do you have a rough timeframe for when you'll be able to look at that failure, so we know whether to back this out or hold off?

Thanks :-)

Comment 5

5 years ago
https://hg.mozilla.org/mozilla-central/rev/5a0a22492be2
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla16
(Assignee)

Comment 6

5 years ago
(In reply to Ed Morley [:edmorley] from comment #4)
> Android M3 is pretty much perma-orange due to bug 765136.
> Do you have a rough timeframe for when you'll be able to look at that
> failure, so we know whether to back this out or hold off?
> 
> Thanks :-)

Huh sorry about that. I would say lets disable the test and I will look into it  today. Backing out means event handling in B2G is broken so it's not much better. We only use the contacts event feature in B2G.

Comment 7

5 years ago
(In reply to Gregor Wagner [:gwagner] from comment #6)
> Huh sorry about that. I would say lets disable the test and I will look into
> it  today.

That sounds good to me - would you be ok sorting that for me whilst I file the bazillion (unrelated) other new oranges? :-)
You need to log in before you can comment on or make changes to this bug.