Closed
Bug 764669
Opened 13 years ago
Closed 13 years ago
beta branding fails due to missing file
Categories
(Firefox for Android Graveyard :: General, defect)
Tracking
(firefox15 verified)
VERIFIED
FIXED
Firefox 16
| Tracking | Status | |
|---|---|---|
| firefox15 | --- | verified |
People
(Reporter: nalexander, Assigned: nalexander)
References
Details
(Keywords: regression)
Attachments
(2 files)
|
1.12 KB,
text/plain
|
Details | |
|
854 bytes,
patch
|
mbrubeck
:
review+
akeybl
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
In android/branding/beta/content/Makefile.in, I have
LINUX_BRANDING_FILES = \
fennec_40x40.png \
fennec_72x72.png \
$(NULL)
However, the file name is actually fennec_48x48.png. This causes my build to fail.
|
Assignee | |
Comment 1•13 years ago
|
||
|
|
Assignee | |
Comment 2•13 years ago
|
||
|
||
Updated•13 years ago
|
OS: Mac OS X → Android
Hardware: x86 → ARM
|
||
Comment 3•13 years ago
|
||
Comment on attachment 640836 [details] [diff] [review]
patch against m-i
Looks like this was accidentally left over from XUL Fennec, where this file still exists:
http://mxr.mozilla.org/mozilla-central/source/mobile/xul/branding/beta/content/fennec_40x40.png
Attachment #640836 -
Flags: review+
|
|
||
Comment 4•13 years ago
|
||
I accidentally missed this in https://hg.mozilla.org/mozilla-central/rev/bfa1fc8ed444 (bug 740878).
Blocks: 740878
Keywords: regression
|
|
||
Updated•13 years ago
|
status-firefox15:
--- → affected
|
|
Assignee | |
Comment 5•13 years ago
|
||
Comment on attachment 640836 [details] [diff] [review]
patch against m-i
[Approval Request Comment]
Bug caused by (feature/regressing bug #):
Missed in https://hg.mozilla.org/mozilla-central/rev/bfa1fc8ed444 (Bug 740878).
User impact if declined:
Building Fennec with beta branding will fail.
Testing completed (on m-c, etc.):
On m-i.
Risk to taking this patch (and alternatives if risky):
Almost none -- strictly a build time change.
String or UUID changes made by this patch:
None.
Attachment #640836 -
Flags: approval-mozilla-aurora?
|
|
Assignee | |
Comment 6•13 years ago
|
||
Assignee: nobody → nalexander
Status: NEW → ASSIGNED
|
|
Assignee | |
Updated•13 years ago
|
Target Milestone: --- → Firefox 16
|
||
Comment 7•13 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
|
||
Updated•13 years ago
|
Attachment #640836 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
|
|
Assignee | |
Comment 8•13 years ago
|
||
|
|
Assignee | |
Comment 9•13 years ago
|
||
Changed target milestone to 15. Please correct if that is wrong.
Target Milestone: Firefox 16 → Firefox 15
|
|
||
Comment 10•13 years ago
|
||
By convention we set status-firefoxN for branch landings instead of changing the milestone.
Target Milestone: Firefox 15 → Firefox 16
|
||
Updated•13 years ago
|
Status: RESOLVED → VERIFIED
|
||
Updated•5 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•