Closed Bug 764669 Opened 12 years ago Closed 12 years ago

beta branding fails due to missing file

Categories

(Firefox for Android Graveyard :: General, defect)

Product:
Firefox for Android Graveyard
Component:
General
Platform:
ARM
Android
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox15 verified)

Status:
VERIFIED FIXED
Milestone:
Firefox 16
Tracking Flags:
Tracking Status
firefox15 --- verified

People

(Reporter: nalexander, Assigned: nalexander)

References

Details

(Keywords: regression)

Attachments

(2 files)

.mozconfig used in build
1.12 KB, text/plain
Details
patch against m-i
854 bytes, patch
mbrubeck
: review+
akeybl
: approval-mozilla-aurora+
Details | Diff | Splinter Review 
In android/branding/beta/content/Makefile.in, I have

LINUX_BRANDING_FILES = \
	fennec_40x40.png \
	fennec_72x72.png \
	$(NULL)

However, the file name is actually fennec_48x48.png.  This causes my build to fail.
OS: Mac OS X → Android
Hardware: x86 → ARM
Comment on attachment 640836 [details] [diff] [review]
patch against m-i

Looks like this was accidentally left over from XUL Fennec, where this file still exists:
http://mxr.mozilla.org/mozilla-central/source/mobile/xul/branding/beta/content/fennec_40x40.png
Attachment #640836 - Flags: review+
Comment on attachment 640836 [details] [diff] [review]
patch against m-i

[Approval Request Comment]
Bug caused by (feature/regressing bug #):

Missed in https://hg.mozilla.org/mozilla-central/rev/bfa1fc8ed444 (Bug 740878).

User impact if declined:

Building Fennec with beta branding will fail.

Testing completed (on m-c, etc.):

On m-i.

Risk to taking this patch (and alternatives if risky):

Almost none -- strictly a build time change.

String or UUID changes made by this patch:

None.
Attachment #640836 - Flags: approval-mozilla-aurora?
https://hg.mozilla.org/integration/mozilla-inbound/rev/fa86aaa84b91
Assignee: nobody → nalexander
Status: NEW → ASSIGNED
Target Milestone: --- → Firefox 16
https://hg.mozilla.org/mozilla-central/rev/fa86aaa84b91
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Attachment #640836 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Changed target milestone to 15.  Please correct if that is wrong.
Target Milestone: Firefox 16 → Firefox 15
By convention we set status-firefoxN for branch landings instead of changing the milestone.
status-firefox15: affected → fixed
Target Milestone: Firefox 15 → Firefox 16
Status: RESOLVED → VERIFIED
status-firefox15: fixed → verified
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: