764671 - Stop uploading symbols for test programs/libs to the symbol server

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[(not currently active) Ted Mielczarek]

These aren't useful for anything and they're currently wasting 50GB of space. We're going to rm the ones that are there, but we should stop uploading them too.

Comment 1

[(not currently active) Ted Mielczarek]

I wrote a patch that skips *test* and *Test* files, and it works, but there's still a fair bit of junk:
BadPlugin
GoodPlugin
ReadNTLM
ShowAlignments
ShowSSEConfig
SimpleTypeLib
WriteArgument
certutiljs
mangle
modutil
nsIFileEnumerator
nsinstall
pk12util
rdfcat
rdfpoll
shlibsign
ssltunnel
triplescat

I guess I can change it to be an exclusions file and we can just list most of this stuff there. Kind of sucks, but it'd help a bit.

Comment 2

[(not currently active) Ted Mielczarek]

Attachment: Stop uploading symbols for test programs/libs to the symbol server

Here's what I've got so far, including unit tests. This drops $(DIST)/crashreporter-symbols from 35MB to 31MB on my Mac.

Comment 3

[(not currently active) Ted Mielczarek]

Comment on attachment 633231 [details] [diff] [review]
Stop uploading symbols for test programs/libs to the symbol server

Feel like reviewing this, Nick?

Comment 4

[Nick Thomas [:nthomas] (UTC+12)]

Comment on attachment 633231 [details] [diff] [review]
Stop uploading symbols for test programs/libs to the symbol server

Looks fine to me.

Comment 5

[(not currently active) Ted Mielczarek]

I pushed this to try along with my patch for bug 587073, so I'll wait to make sure that doesn't break anything first.

Comment 6

[(not currently active) Ted Mielczarek]

The ideal solution for this would be to only dump symbols for things that wind up in the package, but we have to run buildsymbols before make package to make everything work right. If we rejiggered things a bit so that we had the preprocessed package manifest available we could use that as a whitelist. That's probably a good follow-up.

Comment 7

[Nick Thomas [:nthomas] (UTC+12)]

Comment on attachment 633231 [details] [diff] [review]
Stop uploading symbols for test programs/libs to the symbol server

I meant to ask if the tests will be run in 'make check' or equivalent ? Otherwise they only test the native platform when run.

Comment 8

[Nick Thomas [:nthomas] (UTC+12)]

d'oh, that would be the hunk in toolkit/crashreporter/Makefile.in.

Comment 9

[(not currently active) Ted Mielczarek]

Yeah, they get run during "make check", and I've verified that they pass on Mac/Win/Linux.

Comment 10

[(not currently active) Ted Mielczarek]

https://hg.mozilla.org/integration/mozilla-inbound/rev/602cfef02b3d

Comment 11

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/602cfef02b3d