Closed
Bug 764671
Opened 12 years ago
Closed 12 years ago
Stop uploading symbols for test programs/libs to the symbol server
Categories
(Firefox Build System :: General, defect)
Firefox Build System
General
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla16
People
(Reporter: ted, Assigned: ted)
References
Details
Attachments
(1 file)
13.47 KB,
patch
|
nthomas
:
review+
|
Details | Diff | Splinter Review |
These aren't useful for anything and they're currently wasting 50GB of space. We're going to rm the ones that are there, but we should stop uploading them too.
Assignee | ||
Updated•12 years ago
|
Assignee: nobody → ted.mielczarek
Assignee | ||
Comment 1•12 years ago
|
||
I wrote a patch that skips *test* and *Test* files, and it works, but there's still a fair bit of junk: BadPlugin GoodPlugin ReadNTLM ShowAlignments ShowSSEConfig SimpleTypeLib WriteArgument certutiljs mangle modutil nsIFileEnumerator nsinstall pk12util rdfcat rdfpoll shlibsign ssltunnel triplescat I guess I can change it to be an exclusions file and we can just list most of this stuff there. Kind of sucks, but it'd help a bit.
Assignee | ||
Comment 2•12 years ago
|
||
Here's what I've got so far, including unit tests. This drops $(DIST)/crashreporter-symbols from 35MB to 31MB on my Mac.
Assignee | ||
Comment 3•12 years ago
|
||
Comment on attachment 633231 [details] [diff] [review] Stop uploading symbols for test programs/libs to the symbol server Feel like reviewing this, Nick?
Attachment #633231 -
Flags: review?(nrthomas)
Comment 4•12 years ago
|
||
Comment on attachment 633231 [details] [diff] [review] Stop uploading symbols for test programs/libs to the symbol server Looks fine to me.
Attachment #633231 -
Flags: review?(nrthomas) → review+
Assignee | ||
Comment 5•12 years ago
|
||
I pushed this to try along with my patch for bug 587073, so I'll wait to make sure that doesn't break anything first.
Assignee | ||
Comment 6•12 years ago
|
||
The ideal solution for this would be to only dump symbols for things that wind up in the package, but we have to run buildsymbols before make package to make everything work right. If we rejiggered things a bit so that we had the preprocessed package manifest available we could use that as a whitelist. That's probably a good follow-up.
Comment 7•12 years ago
|
||
Comment on attachment 633231 [details] [diff] [review] Stop uploading symbols for test programs/libs to the symbol server I meant to ask if the tests will be run in 'make check' or equivalent ? Otherwise they only test the native platform when run.
Comment 8•12 years ago
|
||
d'oh, that would be the hunk in toolkit/crashreporter/Makefile.in.
Assignee | ||
Comment 9•12 years ago
|
||
Yeah, they get run during "make check", and I've verified that they pass on Mac/Win/Linux.
Assignee | ||
Comment 10•12 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/602cfef02b3d
Status: NEW → ASSIGNED
Comment 11•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/602cfef02b3d
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla16
Updated•6 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•