764699 - testSearchSuggestions test in robocop throws an exception

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Kartikaya Gupta (email:[e-mail])]

Exception caught during test!
java.lang.RuntimeException: Error setting SuggestClient
	at org.mozilla.fennec.tests.testSearchSuggestions.connectSuggestClient(testSearchSuggestions.java:117)
	at org.mozilla.fennec.tests.testSearchSuggestions.testSearchSuggestions(testSearchSuggestions.java:43)
	at java.lang.reflect.Method.invokeNative(Native Method)
	at java.lang.reflect.Method.invoke(Method.java:521)
	at android.test.InstrumentationTestCase.runMethod(InstrumentationTestCase.java:204)
	at android.test.InstrumentationTestCase.runTest(InstrumentationTestCase.java:194)
	at android.test.ActivityInstrumentationTestCase2.runTest(ActivityInstrumentationTestCase2.java:186)
	at org.mozilla.fennec.tests.BaseTest.runTest(BaseTest.java:80)
	at junit.framework.TestCase.runBare(TestCase.java:127)
	at junit.framework.TestResult$1.protect(TestResult.java:106)
	at junit.framework.TestResult.runProtected(TestResult.java:124)
	at junit.framework.TestResult.run(TestResult.java:109)
	at junit.framework.TestCase.run(TestCase.java:118)
	at android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:169)
	at android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:154)
	at android.test.InstrumentationTestRunner.onStart(InstrumentationTestRunner.java:520)
	at android.app.Instrumentation$InstrumentationThread.run(Instrumentation.java:1447)
Caused by: java.lang.IllegalArgumentException: invalid value for field
	at java.lang.reflect.Field.setField(Native Method)
	at java.lang.reflect.Field.set(Field.java:583)
	at org.mozilla.fennec.tests.testSearchSuggestions.connectSuggestClient(testSearchSuggestions.java:99)
	... 16 more

Comment 1

[Kartikaya Gupta (email:[e-mail])]

This line in testSearchSuggestions is throwing the originating exception:

checkNetworkField.set(false, client);

Comment 2

[Brian Nicholson (:bnicholson)]

Attachment: patch

Thanks - silly mistake. I had pushed a change to this test to try without testing those changes locally, and since it was green, I just assumed it was fine.

This patch passes try (and locally) and shows the expected TEST-PASS messages in the log:
https://tbpl.mozilla.org/?tree=Try&rev=0df4e9635e9b

Comment 3

[Kartikaya Gupta (email:[e-mail])]

Comment on attachment 633187 [details] [diff] [review]
patch

Review of attachment 633187 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM

Comment 4

[Brian Nicholson (:bnicholson)]

http://hg.mozilla.org/integration/mozilla-inbound/rev/13a250b1f0a5

Comment 5

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/13a250b1f0a5