gfxAndroidPlatform::Optimal2DFormatForContent assumes Android only

RESOLVED FIXED in mozilla16

Status

()

RESOLVED FIXED
7 years ago
7 years ago

People

(Reporter: mwu, Assigned: kanru)

Tracking

unspecified
mozilla16
All
Gonk (Firefox OS)
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

7 years ago
gfxAndroidPlatform is also used on gonk so we should return 16 or 24 bit depending on whether the device supports it.
(Assignee)

Comment 1

7 years ago
Created attachment 633406 [details] [diff] [review]
Choose optimal 2D format based on off-screen format.

Removed the specialized case for Android since screen->GetColorDepth(&mScreenDepth); already return 16bpp for Android.
Assignee: nobody → kchen
Attachment #633406 - Flags: review?(joe)
Comment on attachment 633406 [details] [diff] [review]
Choose optimal 2D format based on off-screen format.

Review of attachment 633406 [details] [diff] [review]:
-----------------------------------------------------------------

Lovely. Sorry it took me a little while to review.
Attachment #633406 - Flags: review?(joe) → review+

Comment 4

7 years ago
https://hg.mozilla.org/mozilla-central/rev/e022416669a1
Status: NEW → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.