Closed Bug 764752 Opened 12 years ago Closed 11 years ago

gfxAndroidPlatform::Optimal2DFormatForContent assumes Android only

Categories

(Core :: Graphics, defect)

Product:
Core
Component:
Graphics
Platform:
All
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla16

People

(Reporter: mwu, Assigned: kanru)

References

Details

Attachments

(1 file)

Choose optimal 2D format based on off-screen format.
3.38 KB, patch
joe
: review+
Details | Diff | Splinter Review 
gfxAndroidPlatform is also used on gonk so we should return 16 or 24 bit depending on whether the device supports it.
Removed the specialized case for Android since screen->GetColorDepth(&mScreenDepth); already return 16bpp for Android.
Assignee: nobody → kchen
Attachment #633406 - Flags: review?(joe)
Comment on attachment 633406 [details] [diff] [review]
Choose optimal 2D format based on off-screen format.

Review of attachment 633406 [details] [diff] [review]:
-----------------------------------------------------------------

Lovely. Sorry it took me a little while to review.
Attachment #633406 - Flags: review?(joe) → review+
https://hg.mozilla.org/mozilla-central/rev/e022416669a1
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.