764756 - [skiplist] Fix Android library ignore skiplist referring to fennec or wrong

Status: RESOLVED FIXED

(Socorro :: Backend, task)

Description

[Scoobidiver (away)]

Replace:
* 'data@app@org\.mozilla\.fennec-\d\.apk@classes\.dex@0x.*' by 'data@app@org\.mozilla\.f.*-\d\.*.apk@classes\.dex@0x.*'
* 'mnt@asec@org\.mozilla\.fennec-\d@pkg\.apk@classes\.dex@0x.*' by 'mnt@asec@org\.mozilla\.f.*-\d@pkg\.apk@classes\.dex@0x.*'
* 'org\.mozilla\.fennec-\d\.apk@0x.*' by 'org\.mozilla\.f.*-\d\.apk@0x.*'
* 'system@framework@*\.jar@classes\.dex@0x.*' by 'system@framework@.*\.jar@classes\.dex@0x.*'

Comment 1

[K Lars Lohn [:lars] [:klohn]]

> * 'data@app@org\.mozilla\.fennec-\d\.apk@classes\.dex@0x.*' by 'data@app@org\.mozilla\.f.*-\d\.*.apk@classes\.dex@0x.*'

this substitution looks suspicious.  Please verify the replacement in this fragment:

    \d\.*.apk@

a digit followed by zero or more dots followed by any single character then "apk@" ?

Comment 2

[Robert Kaiser]

It is suspicious, yes. Please don't add the additional "*." there for now, and let's let Scoobidiver clear that one up if needed.
The "f.*" change makes sense without any other there as well.

Comment 3

[K Lars Lohn [:lars] [:klohn]]

I'm going forward with this:

'data@app@org\.mozilla\.f.*-\d\.apk@classes\.dex@0x.*'

see PR 1338 (https://github.com/mozilla/socorro/pull/1338) for the actual change in situ.

Comment 4

[Scoobidiver (away)]

(In reply to K Lars Lohn [:lars] [:klohn] from comment #3)
> I'm going forward with this:
> 'data@app@org\.mozilla\.f.*-\d\.apk@classes\.dex@0x.*'
It was intended to skip signatures like in bp-a3f56ebe-c3dd-49a9-be32-7cec32130716. You guessed right.

Comment 5

[[github robot]]

Commit pushed to master at https://github.com/mozilla/socorro

https://github.com/mozilla/socorro/commit/160daad7edd448bdc8912dddc54aed380cf7bafd
Merge pull request #1338 from twobraids/skiplist-20130716

fixes Bug 764756, fixes Bug 878414, fixes Bug 885443 - skiplist changes