764803 - Add comment box has no background in Opera

Status: RESOLVED FIXED

(Tree Management Graveyard :: TBPL, defect)

Description

[Mihai Sucan [:msucan]]

When I add comments to builds the "add a comment" box has no background in Opera 12. On Firefox and Chrome this box has a semi-transparent black background. The lack of background makes it hard to read the texts in the comment box.

Comment 1

[Mihai Sucan [:msucan]]

This one is easy to fix. In style.css .popupForm has the correct background, but there's also a rule as follows:

.popupForm:nth-child(n) { 
  background: transparent;
}

If I eliminate this rule, the popup shows fine in Opera 12.

Comment 2

[Ed Morley [:emorley]]

Hat breaks the styling for other browsers, since they use an image.

I presume the better fix would be to add -o-border-image to:
.popupForm:nth-child(1n) {
  -moz-border-image: url(../images/hudborderimage.png) 10 18 25 repeat;
  -moz-border-image: url(../images/hudborderimage.png) 10 18 25 fill repeat;
  -webkit-border-image: url(../images/hudborderimage.png) 10 18 25 repeat;
  -webkit-border-image: url(../images/hudborderimage.png) 10 18 25 fill repeat;
  border-image: url(../images/hudborderimage.png) 10 18 25 fill repeat;
  background: transparent;
}

Comment 3

[Mihai Sucan [:msucan]]

Indeed. I just inspected the page with Dragonfly - didn't load up the actual style.css - and that didn't show all of the vendor prefixes.

Comment 4

[Ed Morley [:emorley]]

I don't have Opera installed, have you tested the change in comment 2?

I scan of the stylesheet shows a number of other prefixed properties that are missing the -o- variant. Whilst some of these might since have become unprefixed, are there any others there that leap out at you as missing?

Comment 5

[Mounir Lamouri (:mounir)]

That should work. I just launched Opera Next and all -x-border-image and border-image properties are being ignored.

Comment 6

[Ed Morley [:emorley]]

Attachment: Patch v1

Comment 7

[Ed Morley [:emorley]]

http://hg.mozilla.org/users/mstange_themasta.com/tinderboxpushlog/rev/91352cbbc555

(Mihai, won't be fixed until the push to prod - will request one by the end of this week)