Add comment box has no background in Opera

RESOLVED FIXED

Status

Tree Management Graveyard
TBPL
RESOLVED FIXED
6 years ago
3 years ago

People

(Reporter: msucan, Assigned: emorley)

Tracking

Dependency tree / graph

Details

Attachments

(1 attachment)

(Reporter)

Description

6 years ago
When I add comments to builds the "add a comment" box has no background in Opera 12. On Firefox and Chrome this box has a semi-transparent black background. The lack of background makes it hard to read the texts in the comment box.
(Reporter)

Comment 1

6 years ago
This one is easy to fix. In style.css .popupForm has the correct background, but there's also a rule as follows:

.popupForm:nth-child(n) { 
  background: transparent;
}

If I eliminate this rule, the popup shows fine in Opera 12.
(Assignee)

Comment 2

6 years ago
Hat breaks the styling for other browsers, since they use an image.

I presume the better fix would be to add -o-border-image to:
.popupForm:nth-child(1n) {
  -moz-border-image: url(../images/hudborderimage.png) 10 18 25 repeat;
  -moz-border-image: url(../images/hudborderimage.png) 10 18 25 fill repeat;
  -webkit-border-image: url(../images/hudborderimage.png) 10 18 25 repeat;
  -webkit-border-image: url(../images/hudborderimage.png) 10 18 25 fill repeat;
  border-image: url(../images/hudborderimage.png) 10 18 25 fill repeat;
  background: transparent;
}
(Reporter)

Comment 3

6 years ago
Indeed. I just inspected the page with Dragonfly - didn't load up the actual style.css - and that didn't show all of the vendor prefixes.
(Assignee)

Comment 4

6 years ago
I don't have Opera installed, have you tested the change in comment 2?

I scan of the stylesheet shows a number of other prefixed properties that are missing the -o- variant. Whilst some of these might since have become unprefixed, are there any others there that leap out at you as missing?
That should work. I just launched Opera Next and all -x-border-image and border-image properties are being ignored.
(Assignee)

Comment 6

6 years ago
Created attachment 634981 [details] [diff] [review]
Patch v1
Assignee: nobody → bmo
Status: NEW → ASSIGNED
Attachment #634981 - Flags: review?(mounir)
Attachment #634981 - Flags: review?(mounir) → review+
(Assignee)

Comment 7

6 years ago
http://hg.mozilla.org/users/mstange_themasta.com/tinderboxpushlog/rev/91352cbbc555

(Mihai, won't be fixed until the push to prod - will request one by the end of this week)
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
(Assignee)

Updated

6 years ago
Depends on: 767522
Product: Webtools → Tree Management
Product: Tree Management → Tree Management Graveyard
You need to log in before you can comment on or make changes to this bug.