Closed Bug 76484 Opened 23 years ago Closed 22 years ago
Allow multiple Quick
Search forms in a single document
The QuickSearch documentation should be able to present examples the same way Google does, so that the user can modify them and/or submit them directly from the documentation page. See http://www.google.com/help/basics.html and http://www.google.com/help/refinesearch.html for example pages. For this to work, it must be possible to have multiple QuickSearch forms in a single document. This is currently impossible because the functions in quicksearch.js don't take any arguments, they read the value from a hardcoded location instead (document.f.id.value or something like this). This has to be changed so that a) the value or b) the textbox form element or c) the form itself is passed as an argument to the JS function. - a) and b) are very similar; the only difference is that - An advantage of c) is that the interface would not need to be changed in case QuickSearch is extended by additional, optional form elements (radio buttons, checkboxes, ...), so that quicksearch.js could support these new elements but still be backwards compatible. - A disadvantage of c) is that name="id" for the textbox would still have to be hardcoded. Feel free to take this one if you like. Currently I have no time, but maybe in two weeks...
I have seen Jake working on something that looks like option a). See bug 37339, attachment 40917 [details] [diff] [review] ("updated patch to quicksearch", 2001-07-28). Anyway, this is the next thing on my list. Reassigning to Jake in the hope that we can do this together. (Feel free to push it back to me or nobody if you don't want it.) By the way, quicksearchhack.html probably needs the same change as quicksearch.html and index.html.
Assignee: nobody → jake
Yes, quicksearchhack.html will need that change, too. http://landfill.tequilarista.org/bz37339/ is currently running w/this patch on it, so feel free to test it there.
Priority: -- → P3
Target Milestone: Future → Bugzilla 2.16
Component: Bugzilla → Query/Bug List
Product: Webtools → Bugzilla
Version: Bugzilla 2.11 → 2.11
blocks a P1, therefore it's a P1
Priority: P3 → P1
Based on comments, it looks like this was fixed when the patch on bug 37339 was checked in.
Status: ASSIGNED → RESOLVED
Closed: 22 years ago
Resolution: --- → FIXED
Verified fixed: index.tmpl now calls QuickSearch(f.id.value), see http://lxr.mozilla.org/mozilla/source/webtools/bugzilla/template/default/index.tmpl#67
Status: RESOLVED → VERIFIED
QA Contact: matty_is_a_geek → default-qa
You need to log in before you can comment on or make changes to this bug.