Animating the width/height of an outer SVG element doesn't work

VERIFIED FIXED in Firefox 14

Status

()

defect
VERIFIED FIXED
7 years ago
7 years ago

People

(Reporter: longsonr, Assigned: longsonr)

Tracking

({regression})

Trunk
mozilla16
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(firefox13 affected, firefox14 verified, firefox15 verified)

Details

(URL)

Attachments

(1 attachment, 1 obsolete attachment)

Comment hidden (empty)
(Assignee)

Comment 1

7 years ago
Worked in Firefox 8 doesn't work from 12 onwards.

Another example is: http://hoffmann.bplaced.net/svgtest/widthheight02.svg
OS: Windows 7 → All
Hardware: x86_64 → All
(Assignee)

Updated

7 years ago
Keywords: regression
(Assignee)

Comment 3

7 years ago
Posted patch patch (obsolete) — Splinter Review
Assignee: nobody → longsonr
Attachment #633551 - Flags: review?(jwatt)
Comment on attachment 633551 [details] [diff] [review]
patch

Please add a comment along the lines of the following at the start of nsSVGElement::GetAnimatedAttr:

  // We check mapped-into-style attributes first so that animations
  // targeting width/height on outer-<svg> don't appear to be ignored
  // because we returned a nsISMILAttr for the corresponding
  // SVGAnimatedLength.
Attachment #633551 - Flags: review?(jwatt) → review+
(Assignee)

Comment 6

7 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/1a625cb42f58
Flags: in-testsuite+
Target Milestone: --- → mozilla16
(Assignee)

Updated

7 years ago
Blocks: 688430
https://hg.mozilla.org/mozilla-central/rev/1a625cb42f58
Status: NEW → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
(Assignee)

Comment 8

7 years ago
Comment on attachment 633795 [details] [diff] [review]
updated with comments and extra tweak to pass try

[Approval Request Comment]
Bug caused by (feature/regressing bug #): bug 668163
User impact if declined: width/height animations on outer svg won't work.
Testing completed (on m-c, etc.): passed tests on m-c, new tests added
Risk to taking this patch (and alternatives if risky): very low
String or UUID changes made by this patch: none
Attachment #633795 - Flags: approval-mozilla-beta?
Attachment #633795 - Flags: approval-mozilla-aurora?
Comment on attachment 633795 [details] [diff] [review]
updated with comments and extra tweak to pass try

[Triage Comment]
Fairly recent, low risk SVG regression. Approving for Aurora/Beta.
Attachment #633795 - Flags: approval-mozilla-beta?
Attachment #633795 - Flags: approval-mozilla-beta+
Attachment #633795 - Flags: approval-mozilla-aurora?
Attachment #633795 - Flags: approval-mozilla-aurora+
Verified fixed on FF 14b9 on Win 7, Ubuntu 12.04 and Mac OS X 10.6.
Verified fixed on FF 15b3 on Win 7, Ubuntu 12.04 and Mac OS X 10.6.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.