764851 - Animating the width/height of an outer SVG element doesn't work

Status: VERIFIED FIXED

(Core :: SVG, defect)

Comment 1

[Robert Longson [:longsonr]]

Worked in Firefox 8 doesn't work from 12 onwards.

Another example is: http://hoffmann.bplaced.net/svgtest/widthheight02.svg

Comment 2

[Robert Longson [:longsonr]]

regression range:

http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=6f4f2e53694b&tochange=b87861e50640

Comment 3

[Robert Longson [:longsonr]]

Attachment: patch

Comment 4

[Jonathan Watt [:jwatt]]

Comment on attachment 633551 [details] [diff] [review]
patch

Please add a comment along the lines of the following at the start of nsSVGElement::GetAnimatedAttr:

  // We check mapped-into-style attributes first so that animations
  // targeting width/height on outer-<svg> don't appear to be ignored
  // because we returned a nsISMILAttr for the corresponding
  // SVGAnimatedLength.

Comment 5

[Robert Longson [:longsonr]]

Attachment: updated with comments and extra tweak to pass try

Comment 6

[Robert Longson [:longsonr]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/1a625cb42f58

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/1a625cb42f58

Comment 8

[Robert Longson [:longsonr]]

Comment on attachment 633795 [details] [diff] [review]
updated with comments and extra tweak to pass try

[Approval Request Comment]
Bug caused by (feature/regressing bug #): bug 668163
User impact if declined: width/height animations on outer svg won't work.
Testing completed (on m-c, etc.): passed tests on m-c, new tests added
Risk to taking this patch (and alternatives if risky): very low
String or UUID changes made by this patch: none

Comment 9

[Alex Keybl [:akeybl]]

Comment on attachment 633795 [details] [diff] [review]
updated with comments and extra tweak to pass try

[Triage Comment]
Fairly recent, low risk SVG regression. Approving for Aurora/Beta.

Comment 10

[Daniel Holbert [:dholbert]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/9d7c2b626f17
https://hg.mozilla.org/releases/mozilla-beta/rev/bc003244b5c9

Comment 11

[Paul Silaghi, QA [:pauly]]

Verified fixed on FF 14b9 on Win 7, Ubuntu 12.04 and Mac OS X 10.6.

Comment 12

[Paul Silaghi, QA [:pauly]]

Verified fixed on FF 15b3 on Win 7, Ubuntu 12.04 and Mac OS X 10.6.