764860 - Simplify the clipPath code

Status: RESOLVED FIXED

(Core :: SVG, defect)

Description

[Jonathan Watt [:jwatt]]

We can simplify the clipPath code by making it a lot clearer what we actually do when we have a trivial clipPath, and by killing off the unused SVGAutoRenderState::CLIP.

Comment 1

[Jonathan Watt [:jwatt]]

Attachment: patch

Comment 2

[Robert Longson [:longsonr]]

Comment on attachment 633159 [details] [diff] [review]
patch

If we took this we'd fail:

masking-path-02-b.svg
masking-path-05-f.svg
masking-path-07-b.svg
masking-path-08-b.svg
masking-path-09-b.svg

from the SVG testsuite.

Comment 3

[Robert Longson [:longsonr]]

Oh and the Firefox UI is now broken as the address bar has disappeared.

Comment 4

[Jonathan Watt [:jwatt]]

Yeah, I can't get rid of CLIP. New patch coming shortly.

Comment 5

[Robert Longson [:longsonr]]

If the original patch passes our existing reftests, we need more reftests.

Comment 6

[Jonathan Watt [:jwatt]]

Attachment: patch

No, it doesn't pass them.

Comment 7

[Robert Longson [:longsonr]]

And this one does, as well as passing all the SVG testsuite masking-path tests and I get to keep the Firefox address bar ;-)

Comment 8

[Robert Longson [:longsonr]]

Comment 7 is really a question.

Comment 9

[Jonathan Watt [:jwatt]]

Attachment: patch

It does if I dereference aSingleChild properly when assigning to it.

Comment 10

[Jonathan Watt [:jwatt]]

Passed Try: https://tbpl.mozilla.org/?tree=Try&rev=ba7db708631b

Comment 11

[Jonathan Watt [:jwatt]]

Attachment: patch + comments documenting SVGAutoRenderState::RenderMode

Comment 12

[Jonathan Watt [:jwatt]]

I also locally added this for the NORMAL value:

    /**
     * Used to inform SVG frames that they should paint as normal.
     */

Comment 13

[Robert Longson [:longsonr]]

Comment on attachment 633385 [details] [diff] [review]
patch + comments documenting SVGAutoRenderState::RenderMode

r=longsonr provided you've checked the SVG testsuite and all the masking-path tests still pass

Comment 14

[Jonathan Watt [:jwatt]]

Pushed https://hg.mozilla.org/integration/mozilla-inbound/rev/52e4627306f9

Comment 15

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/52e4627306f9