764944 - Kuma: Link editor - Search result list article titles should have entities converted to the actual characters

Status: RESOLVED FIXED

(developer.mozilla.org Graveyard :: Wiki pages, defect)

Description

[Eric Shepherd [:sheppy]]

When drawing items in the search results list in the link dialog, I'm seeing entities (that is, > instead of >, for example). These should be drawn correctly.

Comment 1

[David Walsh :davidwalsh]

Oddly enough, I can't duplicate this issue unless I put "<" and "gt;" in the article title.  If I use the characters, they render just fine:

http://content.screencast.com/users/davidwalsh83/folders/Jing/media/f3d7aa13-27b7-46bf-95f2-02b850d49faf/00000018.png

Can you point me to a live example sheppy?

Comment 2

[David Walsh :davidwalsh]

Sheppy: did MindTouch used to make you add your own entities within titles instead of using the characters themselves?  i.e. you wanted the page title to be "<A> Element", so Mindtouch made you enter "&lt;A&gt; Element"?

Comment 3

[Eric Shepherd [:sheppy]]

No, we just typed the characters themselves.

Comment 4

[David Walsh :davidwalsh]

Sheppy:

http://screencast.com/t/rZof7Bxhlxz

I have a document with "<" and ">" characters in the title and they:

1. Come from the server correctly (you can see the JSON in the console)

2. Display in the autocompleter correctly.

I'd like to resolve this as WORKSFORME.

Comment 5

[David Walsh :davidwalsh]

After speaking with sheppy, and searching developer-new with the term "Element", we believe this is a legacy redirect issue.  Sheppy mentioned in the meeting that the standard for redirects was actually "#Redirect _____", so we may need to tweak this regex to fix the problem:

https://github.com/mozilla/kuma/blob/master/apps/wiki/views.py#L1061

Will confirm with Sheppy.

Comment 6

[David Walsh :davidwalsh]

Update here:

https://github.com/darkwing/kuma/commit/6454cf7d3626ed7af0e05b9beb2d6fde9a2972f4

Comment 7

[Eric Shepherd [:sheppy]]

The syntax for redirects on MindTouch is:

#REDIRECT [[path/to/new/page]]

Comment 8

[[github robot]]

Commits pushed to master at https://github.com/mozilla/kuma

https://github.com/mozilla/kuma/commit/efb7dae345b3cf135fb697308bb31bc51858a06d
fix bug 764944 - Adding '#' to legacy redirect regex to prevent more redirects from displaying in dropdown

https://github.com/mozilla/kuma/commit/8b9878ece002a9cfd649ca42532079f7765acb34
Merge pull request #295 from darkwing/article-title-redirect-764944

fix bug 764944 - Adding '#' to legacy redirect regex to prevent more redirects from displaying in dropdown