Note: There are a few cases of duplicates in user autocompletion which are being worked on.

VisualEventTracer.h: In constructor 'mozilla::eventtracer::AutoEventTracer::AutoEventTracer(...) ...mTypeOff' will be initialized after ...mName' [-Wreorder]

RESOLVED FIXED in mozilla16

Status

()

Core
Networking
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: dholbert, Assigned: dholbert)

Tracking

(Blocks: 1 bug)

Trunk
mozilla16
x86_64
Linux
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
In file included from ../../../mozilla/xpcom/base/VisualEventTracer.cpp:5:0:
../../dist/include/mozilla/VisualEventTracer.h: In constructor 'mozilla::eventtracer::AutoEventTracer::AutoEventTracer(void*, PRUint32, PRUint32, const char*, const char*, const mozilla::detail::GuardObjectNotifier&)':
../../dist/include/mozilla/VisualEventTracer.h:201:12: warning: 'mozilla::eventtracer::AutoEventTracer::mTypeOff' will be initialized after [-Wreorder]
../../dist/include/mozilla/VisualEventTracer.h:198:16: warning:   'const char* mozilla::eventtracer::AutoEventTracer::mName' [-Wreorder]
../../dist/include/mozilla/VisualEventTracer.h:174:3: warning:   when initialized here [-Wreorder]
(Assignee)

Comment 1

5 years ago
Created attachment 633296 [details] [diff] [review]
fix
Assignee: nobody → dholbert
Status: NEW → ASSIGNED
Attachment #633296 - Flags: review?(bugs)
(Assignee)

Comment 2

5 years ago
(attached patch makes the init list ordering match the class declaration, here:
 http://hg.mozilla.org/mozilla-central/annotate/e24844e280a0/xpcom/base/VisualEventTracer.h#l196
and it fixes the warning in my local build.)

Comment 3

5 years ago
Comment on attachment 633296 [details] [diff] [review]
fix

No idea how bug 734015 could have caused this.
Attachment #633296 - Flags: review?(bugs) → review+
(Assignee)

Comment 4

5 years ago
(In reply to Olli Pettay [:smaug] from comment #3)
> Comment on attachment 633296 [details] [diff] [review]
> fix
> 
> No idea how bug 734015 could have caused this.

Oops, sorry! Meant to blame bug 729182 (which added this code), but somehow ended up at the other bug instead.

Thanks for the r+.
Blocks: 729182
No longer blocks: 734015
Component: DOM → Networking
QA Contact: general → networking
(Assignee)

Comment 5

5 years ago
(In reply to Daniel Holbert [:dholbert] from comment #4)
> but somehow ended up at the other bug instead.

(Ah, I accidentally copypasted the bug number from the top of the hgweb file-view page, rather than the blamed-cset-view page.)  (and of course the file-view page just shows the most recent cset that has landed anywhere in the tree, regardless of whether it touched that particular file.)
(Assignee)

Comment 6

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/bc964663cb06
Target Milestone: --- → mozilla16

Comment 7

5 years ago
https://hg.mozilla.org/mozilla-central/rev/bc964663cb06
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.