Closed
Bug 765041
Opened 13 years ago
Closed 13 years ago
VisualEventTracer.h: In constructor 'mozilla::eventtracer::AutoEventTracer::AutoEventTracer(...) ...mTypeOff' will be initialized after ...mName' [-Wreorder]
Categories
(Core :: Networking, defect)
Tracking
()
RESOLVED
FIXED
mozilla16
People
(Reporter: dholbert, Assigned: dholbert)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
1.01 KB,
patch
|
smaug
:
review+
|
Details | Diff | Splinter Review |
In file included from ../../../mozilla/xpcom/base/VisualEventTracer.cpp:5:0:
../../dist/include/mozilla/VisualEventTracer.h: In constructor 'mozilla::eventtracer::AutoEventTracer::AutoEventTracer(void*, PRUint32, PRUint32, const char*, const char*, const mozilla::detail::GuardObjectNotifier&)':
../../dist/include/mozilla/VisualEventTracer.h:201:12: warning: 'mozilla::eventtracer::AutoEventTracer::mTypeOff' will be initialized after [-Wreorder]
../../dist/include/mozilla/VisualEventTracer.h:198:16: warning: 'const char* mozilla::eventtracer::AutoEventTracer::mName' [-Wreorder]
../../dist/include/mozilla/VisualEventTracer.h:174:3: warning: when initialized here [-Wreorder]
Assignee | ||
Comment 1•13 years ago
|
||
Assignee | ||
Comment 2•13 years ago
|
||
(attached patch makes the init list ordering match the class declaration, here:
http://hg.mozilla.org/mozilla-central/annotate/e24844e280a0/xpcom/base/VisualEventTracer.h#l196
and it fixes the warning in my local build.)
Comment 3•13 years ago
|
||
Comment on attachment 633296 [details] [diff] [review]
fix
No idea how bug 734015 could have caused this.
Attachment #633296 -
Flags: review?(bugs) → review+
Assignee | ||
Comment 4•13 years ago
|
||
(In reply to Olli Pettay [:smaug] from comment #3)
> Comment on attachment 633296 [details] [diff] [review]
> fix
>
> No idea how bug 734015 could have caused this.
Oops, sorry! Meant to blame bug 729182 (which added this code), but somehow ended up at the other bug instead.
Thanks for the r+.
Assignee | ||
Comment 5•13 years ago
|
||
(In reply to Daniel Holbert [:dholbert] from comment #4)
> but somehow ended up at the other bug instead.
(Ah, I accidentally copypasted the bug number from the top of the hgweb file-view page, rather than the blamed-cset-view page.) (and of course the file-view page just shows the most recent cset that has landed anywhere in the tree, regardless of whether it touched that particular file.)
Assignee | ||
Comment 6•13 years ago
|
||
Target Milestone: --- → mozilla16
Comment 7•13 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•