765041 - VisualEventTracer.h: In constructor 'mozilla::eventtracer::AutoEventTracer::AutoEventTracer(...) ...mTypeOff' will be initialized after ...mName' [-Wreorder]

Status: RESOLVED FIXED

(Core :: Networking, defect)

Description

[Daniel Holbert [:dholbert]]

In file included from ../../../mozilla/xpcom/base/VisualEventTracer.cpp:5:0:
../../dist/include/mozilla/VisualEventTracer.h: In constructor 'mozilla::eventtracer::AutoEventTracer::AutoEventTracer(void*, PRUint32, PRUint32, const char*, const char*, const mozilla::detail::GuardObjectNotifier&)':
../../dist/include/mozilla/VisualEventTracer.h:201:12: warning: 'mozilla::eventtracer::AutoEventTracer::mTypeOff' will be initialized after [-Wreorder]
../../dist/include/mozilla/VisualEventTracer.h:198:16: warning:   'const char* mozilla::eventtracer::AutoEventTracer::mName' [-Wreorder]
../../dist/include/mozilla/VisualEventTracer.h:174:3: warning:   when initialized here [-Wreorder]

Comment 1

[Daniel Holbert [:dholbert]]

Attachment: fix

Comment 2

[Daniel Holbert [:dholbert]]

(attached patch makes the init list ordering match the class declaration, here:
 http://hg.mozilla.org/mozilla-central/annotate/e24844e280a0/xpcom/base/VisualEventTracer.h#l196
and it fixes the warning in my local build.)

Comment 3

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 633296 [details] [diff] [review]
fix

No idea how bug 734015 could have caused this.

Comment 4

[Daniel Holbert [:dholbert]]

(In reply to Olli Pettay [:smaug] from comment #3)
> Comment on attachment 633296 [details] [diff] [review]
> fix
> 
> No idea how bug 734015 could have caused this.

Oops, sorry! Meant to blame bug 729182 (which added this code), but somehow ended up at the other bug instead.

Thanks for the r+.

Comment 5

[Daniel Holbert [:dholbert]]

(In reply to Daniel Holbert [:dholbert] from comment #4)
> but somehow ended up at the other bug instead.

(Ah, I accidentally copypasted the bug number from the top of the hgweb file-view page, rather than the blamed-cset-view page.)  (and of course the file-view page just shows the most recent cset that has landed anywhere in the tree, regardless of whether it touched that particular file.)

Comment 6

[Daniel Holbert [:dholbert]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/bc964663cb06

Comment 7

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/bc964663cb06