Last Comment Bug 765041 - VisualEventTracer.h: In constructor 'mozilla::eventtracer::AutoEventTracer::AutoEventTracer(...) ...mTypeOff' will be initialized after ...mName' [-Wreorder]
: VisualEventTracer.h: In constructor 'mozilla::eventtracer::AutoEventTracer::A...
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: Networking (show other bugs)
: Trunk
: x86_64 Linux
: -- normal (vote)
: mozilla16
Assigned To: Daniel Holbert [:dholbert] (mostly OOTO until Aug 9th)
:
Mentors:
Depends on:
Blocks: buildwarning 729182
  Show dependency treegraph
 
Reported: 2012-06-14 15:05 PDT by Daniel Holbert [:dholbert] (mostly OOTO until Aug 9th)
Modified: 2012-06-15 05:57 PDT (History)
1 user (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
fix (1.01 KB, patch)
2012-06-14 15:08 PDT, Daniel Holbert [:dholbert] (mostly OOTO until Aug 9th)
bugs: review+
Details | Diff | Splinter Review

Description Daniel Holbert [:dholbert] (mostly OOTO until Aug 9th) 2012-06-14 15:05:23 PDT
In file included from ../../../mozilla/xpcom/base/VisualEventTracer.cpp:5:0:
../../dist/include/mozilla/VisualEventTracer.h: In constructor 'mozilla::eventtracer::AutoEventTracer::AutoEventTracer(void*, PRUint32, PRUint32, const char*, const char*, const mozilla::detail::GuardObjectNotifier&)':
../../dist/include/mozilla/VisualEventTracer.h:201:12: warning: 'mozilla::eventtracer::AutoEventTracer::mTypeOff' will be initialized after [-Wreorder]
../../dist/include/mozilla/VisualEventTracer.h:198:16: warning:   'const char* mozilla::eventtracer::AutoEventTracer::mName' [-Wreorder]
../../dist/include/mozilla/VisualEventTracer.h:174:3: warning:   when initialized here [-Wreorder]
Comment 1 Daniel Holbert [:dholbert] (mostly OOTO until Aug 9th) 2012-06-14 15:08:46 PDT
Created attachment 633296 [details] [diff] [review]
fix
Comment 2 Daniel Holbert [:dholbert] (mostly OOTO until Aug 9th) 2012-06-14 15:09:44 PDT
(attached patch makes the init list ordering match the class declaration, here:
 http://hg.mozilla.org/mozilla-central/annotate/e24844e280a0/xpcom/base/VisualEventTracer.h#l196
and it fixes the warning in my local build.)
Comment 3 Olli Pettay [:smaug] 2012-06-14 15:13:58 PDT
Comment on attachment 633296 [details] [diff] [review]
fix

No idea how bug 734015 could have caused this.
Comment 4 Daniel Holbert [:dholbert] (mostly OOTO until Aug 9th) 2012-06-14 15:24:54 PDT
(In reply to Olli Pettay [:smaug] from comment #3)
> Comment on attachment 633296 [details] [diff] [review]
> fix
> 
> No idea how bug 734015 could have caused this.

Oops, sorry! Meant to blame bug 729182 (which added this code), but somehow ended up at the other bug instead.

Thanks for the r+.
Comment 5 Daniel Holbert [:dholbert] (mostly OOTO until Aug 9th) 2012-06-14 15:28:16 PDT
(In reply to Daniel Holbert [:dholbert] from comment #4)
> but somehow ended up at the other bug instead.

(Ah, I accidentally copypasted the bug number from the top of the hgweb file-view page, rather than the blamed-cset-view page.)  (and of course the file-view page just shows the most recent cset that has landed anywhere in the tree, regardless of whether it touched that particular file.)
Comment 6 Daniel Holbert [:dholbert] (mostly OOTO until Aug 9th) 2012-06-14 15:41:32 PDT
https://hg.mozilla.org/integration/mozilla-inbound/rev/bc964663cb06
Comment 7 Ed Morley [:emorley] 2012-06-15 05:57:46 PDT
https://hg.mozilla.org/mozilla-central/rev/bc964663cb06

Note You need to log in before you can comment on or make changes to this bug.