Closed Bug 765065 Opened 7 years ago Closed 7 years ago

Annotation for crash reports: "Are we GCing?"


(Core :: XPConnect, enhancement)

Not set



Tracking Status
firefox15 --- fixed
firefox16 --- fixed


(Reporter: jruderman, Assigned: billm)



(1 file)

This would allow us to gather statistics on GC crashes more easily -- and even if stack walking fails.

(For bonus points, say whether it's a compartment / multi-compartment / global GC)
This is a little bit of a PITA, because only the JS engine knows if we're GCing, right? And the JS engine doesn't know how to talk to Breakpad directly. Do we have a callback that happens when we enter/leave GC where Gecko could add this annotation?
Yeah, xpconnect already knows when we're in a GC, and it can talk to breakpad.
Assignee: general → nobody
Component: JavaScript Engine → XPConnect
QA Contact: general → xpconnect
We can either dump it in the xpconnect callback ( or register a special callback ( to do so, which is conceptually a bit cleaner.
Attached patch patchSplinter Review
This seems to do the job, at least on Linux.
Assignee: nobody → wmccloskey
Attachment #651060 - Flags: review?(benjamin)
Comment on attachment 651060 [details] [diff] [review]

Remove the stray printf in CrashReporter::SetGarbageCollecting. I'm torn on whether we should be writing "IsGarbageCollecting=0" ever; perhaps it would be better to only write that field if we are garbage collecting?
Attachment #651060 - Flags: review?(benjamin) → review+
Comment on attachment 651060 [details] [diff] [review]

Just a note about this request:
This patch doesn't fix any bugs. It just adds data to crashreports that make it easier to see which crashes are GC-related. Given that incremental GC landed in FF16, it would be really useful to be able to compare crash rates between 15 and 16. That's why I'm requesting beta approval.

[Approval Request Comment]
Bug caused by (feature/regressing bug #): None.
User impact if declined: None.
Testing completed (on m-c, etc.): On m-c.
Risk to taking this patch (and alternatives if risky): Very low.
String or UUID changes made by this patch: None.
Attachment #651060 - Flags: approval-mozilla-beta?
Attachment #651060 - Flags: approval-mozilla-aurora?
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla17
Comment on attachment 651060 [details] [diff] [review]

Approving for branches so we're able to get better crash data.
Attachment #651060 - Flags: approval-mozilla-beta?
Attachment #651060 - Flags: approval-mozilla-beta+
Attachment #651060 - Flags: approval-mozilla-aurora?
Attachment #651060 - Flags: approval-mozilla-aurora+
You need to log in before you can comment on or make changes to this bug.