Closed
Bug 765086
Opened 13 years ago
Closed 13 years ago
Allow userShutdown also from any setup/teardown method
Categories
(Testing Graveyard :: Mozmill, defect)
Testing Graveyard
Mozmill
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: whimboo, Assigned: whimboo)
References
Details
(Whiteboard: [mozmill-2.0][mozmill-1.5.13+])
Attachments
(2 files)
Right now as implemented on bug 567108, the user shutdown only works from within the test method itself. We should not force that but let the test restart the application from whatever the state is. It's a simple fix by just letting the observer for 'quit-application' running a bit longer.
https://github.com/mozautomation/mozmill/commit/1ed51ce30ac0c653281bf049b8f170e7f975267c#L1R557
I would like to see this also fixed in Mozmill 1.5.13 so that we can re-enable a couple of our tests without having to do workarounds.
|
Assignee | |
Comment 1•13 years ago
|
||
While working on this patch I have seen that for Mozmill 2.0 we do not restart the application if a usershutdown fails. Instead we directly execute the next test in the sequence. I will file that as a new bug.
|
|
Assignee | |
Comment 2•13 years ago
|
||
Pointer to Github pull-request
|
|
Assignee | |
Comment 3•13 years ago
|
||
Comment on attachment 633337 [details]
Patch (Mozmill 2.0)
This implements the feature to be also able to restart the application via an user restart in the setup/teardown related functions.
If you want to test this please run the tests on its own. Otherwise they will fail given the before mentioned issue.
Attachment #633337 -
Attachment description: Pointer to Github pull request: https://github.com/mozautomation/mozmill/pull/46/files → Patch (Mozmill 2.0)
Attachment #633337 -
Flags: review?(jhammel)
|
|
Assignee | |
Comment 4•13 years ago
|
||
Pointer to Github pull-request
|
|
Assignee | |
Comment 5•13 years ago
|
||
Comment on attachment 633341 [details]
Patch (Mozmill 1.5)
When you want to test the patch on 1.5 you can safely run all the tests. It will run smoothly.
Attachment #633341 -
Attachment description: Pointer to Github pull request: https://github.com/mozautomation/mozmill/pull/47 → Patch (Mozmill 1.5)
Attachment #633341 -
Flags: review?(jhammel)
|
|
Assignee | |
Updated•13 years ago
|
Attachment #633337 -
Flags: review?(jhammel) → review?(ahalberstadt)
|
|
Assignee | |
Updated•13 years ago
|
Attachment #633341 -
Flags: review?(jhammel) → review?(ahalberstadt)
|
||
Comment 6•13 years ago
|
||
Comment on attachment 633337 [details]
Patch (Mozmill 2.0)
Looks good, r+
Attachment #633337 -
Flags: review?(ahalberstadt) → review+
|
|
||
Updated•13 years ago
|
Attachment #633341 -
Flags: review?(ahalberstadt) → review+
|
|
Assignee | |
Comment 7•13 years ago
|
||
Pushed:
https://github.com/mozautomation/mozmill/commit/13c26ccde1b8765f11c14a2a4d7e6a4ac6c8ba33 (master)
https://github.com/mozautomation/mozmill/commit/351667a0ed22d12efe83a331dbf6753add97711f (hotfix-1.5)
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
|
|
Assignee | |
Updated•13 years ago
|
Summary: Allow usershutdown also from any setup/teardown module → Allow userShutdown also from any setup/teardown method
|
|
Assignee | |
Comment 8•13 years ago
|
||
This fix has been shipped with Mozmill 1.5.13.
Whiteboard: [mozmill-2.0?][mozmill-1.5.13?] → [mozmill-2.0][mozmill-1.5.13+]
|
||
Updated•9 years ago
|
Product: Testing → Testing Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•