765110 - TextLeafAccessibleWrap is never instanciated

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[Hubert Figuiere [:hub]]

TextLeafAccessibleWrap is never instanciated. Only the MSAA backend define the class, but the nsAccessibilityService implementation will not instanciate it, sticking to TextLeafAccessible.

Comment 1

[Mark Capella [:capella]]

Attachment: Patch (v1)

I imagine this is just this small change ... coidng is simple, but how do I test it / see the before and after effects for myself? I'm tinkering around with DOMInspector and ACCProbe ... but they're relatively new tools to me, and maybe I just don't know where to look ....

Comment 2

[Mark Capella [:capella]]

(regression from bug 745428 - my bad!)

Push to TRY:
https://tbpl.mozilla.org/?tree=Try&rev=161957dc4af5

Comment 3

[Hubert Figuiere [:hub]]

Now I filed the bug but never tested anything. I just found it out trying to do stuff on Mac.

Does it really have an impact on Windows?

Comment 4

[Mark Capella [:capella]]

Dang ... other people 
https://tbpl.mozilla.org/?tree=Try&rev=da6c03ac176f

Comment 5

[alexander :surkov (:asurkov)]

(In reply to Mark Capella [:capella] from comment #1)
> Created attachment 637091 [details] [diff] [review]
> Patch (v1)
> 
> I imagine this is just this small change ... coidng is simple, but how do I
> test it / see the before and after effects for myself? I'm tinkering around
> with DOMInspector and ACCProbe ... but they're relatively new tools to me,
> and maybe I just don't know where to look ....

This class implements ISimpleDOMText interface, I don't think we have tools to test it. 

Please make sure to get an approval for aurora where we regressed since this interface is used by AT.

Hub, thanks for the catch.

Comment 6

[Mark Capella [:capella]]

https://tbpl.mozilla.org/?tree=Mozilla-Inbound&rev=dcf8693ba5e1

Comment 7

[Ed Morley [:emorley]]

Sorry, this merged yesterday, but I completely forgot to do the bug marking:
https://hg.mozilla.org/mozilla-central/rev/dcf8693ba5e1

Comment 8

[Trevor Saunders (:tbsaunde)]

Comment on attachment 637091 [details] [diff] [review]
Patch (v1)

[Approval Request Comment]
Bug caused by (feature/regressing bug #):  745428
User impact if declined:  certain assistive technology on windows may have trouble accessing text of web page elements.
Testing completed (on m-c, etc.): yes
Risk to taking this patch (and alternatives if risky): extremely low.  it changes nothing on platforms other than windows.  On windows there nothing is removed, but an interface that we stopped exposing to screen readers will be exposed again.  nothing has changed in the implementation, so it should be very safe.
String or UUID changes made by this patch:  none

Comment 9

[Alex Keybl [:akeybl]]

Comment on attachment 637091 [details] [diff] [review]
Patch (v1)

[Triage Comment]
Low risk a11y fix for a FF15 regression. Approved for Aurora 15.

Comment 10

[Marco Zehe (:MarcoZ)]

http://hg.mozilla.org/releases/mozilla-aurora/rev/a45c99cca5e5