Closed
Bug 765116
Opened 13 years ago
Closed 13 years ago
mozglue/android: fix gcc -Wall -pedantic warnings
Categories
(Firefox for Android Graveyard :: General, defect)
Tracking
(firefox16 fixed)
RESOLVED
FIXED
Firefox 16
| Tracking | Status | |
|---|---|---|
| firefox16 | --- | fixed |
People
(Reporter: cpeterson, Assigned: cpeterson)
Details
Attachments
(2 files)
|
2.68 KB,
patch
|
glandium
:
review+
|
Details | Diff | Splinter Review |
|
6.80 KB,
patch
|
glandium
:
review+
|
Details | Diff | Splinter Review |
No description provided.
|
Assignee | |
Comment 1•13 years ago
|
||
Part 1: mozglue/android: fix gcc -Wall warnings
Attachment #633361 -
Flags: review?(mh+mozilla)
|
|
Assignee | |
Comment 2•13 years ago
|
||
Part 2: mozglue/android: fix gcc -pedantic warnings
gcc -pedantic warns about dlsym() casts because ISO C does not guarantee that sizeof(function pointer) == sizeof(void*), though that would be an unusual machine architecture. To suppress these warnings, this patch casts dlsym()'s return value from void* to uintptr_t to a function pointer.
Attachment #633362 -
Flags: review?(mh+mozilla)
|
||
Updated•13 years ago
|
Attachment #633361 -
Flags: review?(mh+mozilla) → review+
|
|
||
Updated•13 years ago
|
Attachment #633362 -
Flags: review?(mh+mozilla) → review+
|
|
Assignee | |
Comment 3•13 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/00f19e7b179b
https://hg.mozilla.org/integration/mozilla-inbound/rev/380fd6ee7ded
Status: NEW → ASSIGNED
status-firefox16:
--- → fixed
|
||
Comment 4•13 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/00f19e7b179b
https://hg.mozilla.org/mozilla-central/rev/380fd6ee7ded
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
|
||
Updated•5 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•