mozglue/android: fix gcc -Wall -pedantic warnings

RESOLVED FIXED in Firefox 16

Status

()

Firefox for Android
General
--
minor
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: cpeterson, Assigned: cpeterson)

Tracking

Trunk
Firefox 16
ARM
Android
Points:
---

Firefox Tracking Flags

(firefox16 fixed)

Details

Attachments

(2 attachments)

Comment hidden (empty)
(Assignee)

Comment 1

5 years ago
Created attachment 633361 [details] [diff] [review]
part-1-fix-Wall-warnings.patch

Part 1: mozglue/android: fix gcc -Wall warnings
Attachment #633361 - Flags: review?(mh+mozilla)
(Assignee)

Comment 2

5 years ago
Created attachment 633362 [details] [diff] [review]
part-2-fix-pedantic-warnings.patch

Part 2: mozglue/android: fix gcc -pedantic warnings

gcc -pedantic warns about dlsym() casts because ISO C does not guarantee that sizeof(function pointer) == sizeof(void*), though that would be an unusual machine architecture. To suppress these warnings, this patch casts dlsym()'s return value from void* to uintptr_t to a function pointer.
Attachment #633362 - Flags: review?(mh+mozilla)
Attachment #633361 - Flags: review?(mh+mozilla) → review+
Attachment #633362 - Flags: review?(mh+mozilla) → review+
(Assignee)

Comment 3

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/00f19e7b179b
https://hg.mozilla.org/integration/mozilla-inbound/rev/380fd6ee7ded
Status: NEW → ASSIGNED
status-firefox16: --- → fixed

Comment 4

5 years ago
https://hg.mozilla.org/mozilla-central/rev/00f19e7b179b
https://hg.mozilla.org/mozilla-central/rev/380fd6ee7ded
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.