Closed
Bug 765161
Opened 12 years ago
Closed 12 years ago
WebGL crash when empty string is passed to getUniformLocation, getAttribLocation or bindAttribLocation [@mozilla::WebGLProgram::MapIdentifier] (dupe)
Categories
(Core :: Graphics: CanvasWebGL, defect)
Tracking
()
RESOLVED
DUPLICATE
of bug 765179
People
(Reporter: posidron, Unassigned)
Details
(Keywords: crash, sec-other, testcase, Whiteboard: [asan] [sg:dupe 765179])
Attachments
(3 files)
1.74 KB,
text/html
|
Details | |
6.65 KB,
text/plain
|
Details | |
905 bytes,
patch
|
Details | Diff | Splinter Review |
Have only marked this as a sec bug because asan said heap overflow. The second parameter for getUniformLocation() is causing a crash which is an empty string. getUniformLocation(pg, '');
Reporter | ||
Comment 1•12 years ago
|
||
Comment 3•12 years ago
|
||
This should fix it, although i am running in Valgrind at the moment to confirm. Doing it in ValidateGLSLVariableName() allows to fix this bug also in other functions all at once.
Attachment #633541 -
Flags: review?
Updated•12 years ago
|
Attachment #633541 -
Flags: review? → review?(jgilbert)
Updated•12 years ago
|
Summary: WebGL crash with getUniformLocation string [@mozilla::WebGLProgram::MapIdentifier] → WebGL crash when empty string is passed to getUniformLocation, getAttribLocation or bindAttribLocation string [@mozilla::WebGLProgram::MapIdentifier]
Updated•12 years ago
|
Summary: WebGL crash when empty string is passed to getUniformLocation, getAttribLocation or bindAttribLocation string [@mozilla::WebGLProgram::MapIdentifier] → WebGL crash when empty string is passed to getUniformLocation, getAttribLocation or bindAttribLocation [@mozilla::WebGLProgram::MapIdentifier]
Comment 4•12 years ago
|
||
No valgrind errors with this patch.
Comment 5•12 years ago
|
||
Comment on attachment 633541 [details] [diff] [review] check for empty variable names We ended up doing the reviews on the other bug, sorry.
Attachment #633541 -
Flags: review?(jgilbert)
Updated•12 years ago
|
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → DUPLICATE
Updated•12 years ago
|
Whiteboard: [asan] → [asan] [sg:dupe 765179]
Updated•12 years ago
|
Summary: WebGL crash when empty string is passed to getUniformLocation, getAttribLocation or bindAttribLocation [@mozilla::WebGLProgram::MapIdentifier] → WebGL crash when empty string is passed to getUniformLocation, getAttribLocation or bindAttribLocation [@mozilla::WebGLProgram::MapIdentifier] (dupe)
You need to log in
before you can comment on or make changes to this bug.
Description
•