The default bug view has changed. See this FAQ.

Support mode "unknown" when parsing cache manifest

RESOLVED FIXED in mozilla16

Status

()

Core
Networking: Cache
--
enhancement
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: mayhemer, Assigned: mayhemer)

Tracking

Trunk
mozilla16
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(URL)

Attachments

(1 attachment)

Comment hidden (empty)
(Assignee)

Comment 1

5 years ago
We have to allow sections other then e.g. NETWORK, EXPLICIT etc simply by ignoring/skipping them.  This is needed for forward compatibility when the spec adds new sections, as has happened recently.  This should be tracked for FX16 as this is very simple and safe to implement and compat important.
tracking-firefox16: --- → ?

Updated

5 years ago
Assignee: honzab.moz → jschoenick
(Assignee)

Comment 2

5 years ago
Steeling the bug back.  I would like to get this done for Fx16.
Assignee: jschoenick → honzab.moz
(Assignee)

Comment 3

5 years ago
Created attachment 641565 [details] [diff] [review]
v1

- const_iterator doesn't support - operator.. quit sad.
- end cannot be equal to begin since there if it would, the method would exit earlier above (there is if (begin == end || *begin == '#') return NS_OK;)
Attachment #641565 - Flags: review?(jduell.mcbugs)
(Assignee)

Updated

5 years ago
Status: NEW → ASSIGNED

Comment 4

5 years ago
(In reply to Honza Bambas (:mayhemer) from comment #1)
> This should be tracked
> for FX16 as this is very simple and safe to implement and compat important.

The only part of that justification that qualifies for tracking is the compatibility importance. Can you give us more context there? Thanks!
Comment on attachment 641565 [details] [diff] [review]
v1

Both code + test look good.
Attachment #641565 - Flags: review?(jduell.mcbugs) → review+
(Assignee)

Comment 6

5 years ago
(In reply to Alex Keybl [:akeybl] from comment #4)
> The only part of that justification that qualifies for tracking is the
> compatibility importance. Can you give us more context there? Thanks!

In the current-work spec it is marked as ready-for-first-implementation.  I checked with chrome (dev channel) that it supports unknown sections.  There has recently been introduced SETTINGS section, that when encountered by our manifest parser leads to break of the manifest load and thus the whole app doesn't get cached.

I'm going to land this patch now, since it is simple, has a test, and I don't see any reason why we should hold it back.
(Assignee)

Comment 7

5 years ago
Comment on attachment 641565 [details] [diff] [review]
v1

https://hg.mozilla.org/integration/mozilla-inbound/rev/2ff61044edbd
Attachment #641565 - Flags: checkin+
(Assignee)

Updated

5 years ago
tracking-firefox16: ? → ---
https://hg.mozilla.org/mozilla-central/rev/2ff61044edbd
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla16
You need to log in before you can comment on or make changes to this bug.