Closed Bug 765221 Opened 9 years ago Closed 9 years ago

White text shadow for lightweight themes with dark text looks weird

Categories

(Toolkit :: Themes, defect)

defect
Not set
trivial

Tracking

()

RESOLVED FIXED
mozilla16
Tracking Status
firefox15 --- fixed

People

(Reporter: dao, Assigned: dao)

Details

Attachments

(1 file, 1 obsolete file)

Attached patch patch (obsolete) — Splinter Review
A shadow can't be white and the text doesn't look like it's inset either... It makes more sense for the white "shadow" to be above the text as a highlight.
Attachment #633496 - Flags: review?(shorlander)
Is there a specific reason for the horizontal offset? Using just a vertical offset would be more consistent with our other highlight/shadow effects and seems to have about the same effect on legibility.
Attached patch patch v2Splinter Review
no specific reason
Attachment #633496 - Attachment is obsolete: true
Attachment #633496 - Flags: review?(shorlander)
Attachment #641543 - Flags: review?(shorlander)
Comment on attachment 641543 [details] [diff] [review]
patch v2

Review of attachment 641543 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, thank you!
Attachment #641543 - Flags: review?(shorlander) → review+
Comment on attachment 641543 [details] [diff] [review]
patch v2

[Approval Request Comment]
Not a regression fix but risk-free UI polish. Just changing the vertical and horizontal offset parameters of the text shadow.
Attachment #641543 - Flags: approval-mozilla-aurora?
Comment on attachment 641543 [details] [diff] [review]
patch v2

[Triage Comment]
No expected fallout from this polish and still early in the cycle, approved for Aurora 15.
Attachment #641543 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
https://hg.mozilla.org/mozilla-central/rev/ab6a89ec10fe
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.