765221 - White text shadow for lightweight themes with dark text looks weird

Status: RESOLVED FIXED

(Toolkit :: Themes, defect)

Description

[Dão Gottwald [:dao]]

Attachment: patch

A shadow can't be white and the text doesn't look like it's inset either... It makes more sense for the white "shadow" to be above the text as a highlight.

Comment 1

[Stephen Horlander [:shorlander]]

Is there a specific reason for the horizontal offset? Using just a vertical offset would be more consistent with our other highlight/shadow effects and seems to have about the same effect on legibility.

Comment 2

[Dão Gottwald [:dao]]

Attachment: patch v2

no specific reason

Comment 3

[Stephen Horlander [:shorlander]]

Comment on attachment 641543 [details] [diff] [review]
patch v2

Review of attachment 641543 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, thank you!

Comment 4

[Dão Gottwald [:dao]]

http://hg.mozilla.org/integration/mozilla-inbound/rev/ab6a89ec10fe

Comment 5

[Dão Gottwald [:dao]]

Comment on attachment 641543 [details] [diff] [review]
patch v2

[Approval Request Comment]
Not a regression fix but risk-free UI polish. Just changing the vertical and horizontal offset parameters of the text shadow.

Comment 6

[Alex Keybl [:akeybl]]

Comment on attachment 641543 [details] [diff] [review]
patch v2

[Triage Comment]
No expected fallout from this polish and still early in the cycle, approved for Aurora 15.

Comment 7

[Dão Gottwald [:dao]]

http://hg.mozilla.org/releases/mozilla-aurora/rev/88382a387a66

Comment 8

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/ab6a89ec10fe