White text shadow for lightweight themes with dark text looks weird

RESOLVED FIXED in Firefox 15

Status

()

Toolkit
Themes
--
trivial
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: dao, Assigned: dao)

Tracking

Trunk
mozilla16
Points:
---

Firefox Tracking Flags

(firefox15 fixed)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

5 years ago
Created attachment 633496 [details] [diff] [review]
patch

A shadow can't be white and the text doesn't look like it's inset either... It makes more sense for the white "shadow" to be above the text as a highlight.
Attachment #633496 - Flags: review?(shorlander)
Is there a specific reason for the horizontal offset? Using just a vertical offset would be more consistent with our other highlight/shadow effects and seems to have about the same effect on legibility.
(Assignee)

Comment 2

5 years ago
Created attachment 641543 [details] [diff] [review]
patch v2

no specific reason
Attachment #633496 - Attachment is obsolete: true
Attachment #633496 - Flags: review?(shorlander)
Attachment #641543 - Flags: review?(shorlander)
Comment on attachment 641543 [details] [diff] [review]
patch v2

Review of attachment 641543 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, thank you!
Attachment #641543 - Flags: review?(shorlander) → review+
(Assignee)

Comment 4

5 years ago
http://hg.mozilla.org/integration/mozilla-inbound/rev/ab6a89ec10fe
Target Milestone: --- → mozilla16
(Assignee)

Comment 5

5 years ago
Comment on attachment 641543 [details] [diff] [review]
patch v2

[Approval Request Comment]
Not a regression fix but risk-free UI polish. Just changing the vertical and horizontal offset parameters of the text shadow.
Attachment #641543 - Flags: approval-mozilla-aurora?

Comment 6

5 years ago
Comment on attachment 641543 [details] [diff] [review]
patch v2

[Triage Comment]
No expected fallout from this polish and still early in the cycle, approved for Aurora 15.
Attachment #641543 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
(Assignee)

Comment 7

5 years ago
http://hg.mozilla.org/releases/mozilla-aurora/rev/88382a387a66
status-firefox15: --- → fixed

Comment 8

5 years ago
https://hg.mozilla.org/mozilla-central/rev/ab6a89ec10fe
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.