Closed
Bug 765235
Opened 13 years ago
Closed 13 years ago
[New Tab Page] test suite should make use of underlying storages
Categories
(Firefox :: Tabbed Browser, defect)
Firefox
Tabbed Browser
Tracking
()
RESOLVED
FIXED
Firefox 16
People
(Reporter: ttaubert, Assigned: ttaubert)
References
Details
Attachments
(1 file)
|
27.15 KB,
patch
|
Gavin
:
review+
|
Details | Diff | Splinter Review |
The about:newtab test suite should not inject its test data directly into NewTabUtils' objects. We should rather modify the DOMStorage values and add visits to the history service. This way we'll also get test coverage of the components responsible for handling those storages. Also, it's harder to create leaking tests that way.
Those are the changes:
* setPinnedLinks() does now write the value directly to the DOMStorage.
* setLinks() operates asynchronously now and injects its links into places/history.
* I needed to replace about:blank with http://example.com/ because the history service rejects about:blank URIs.
Attachment #633513 -
Flags: review?(dao)
|
Assignee | |
Comment 1•13 years ago
|
||
Try is green:
https://tbpl.mozilla.org/?tree=Try&rev=48e9a7c2c739
|
|
Assignee | |
Updated•13 years ago
|
Attachment #633513 -
Flags: review?(mak77)
|
|
Assignee | |
Comment 2•13 years ago
|
||
Anyone, please?
|
||
Updated•13 years ago
|
Attachment #633513 -
Flags: review?(mak77)
Attachment #633513 -
Flags: review?(dao)
Attachment #633513 -
Flags: review+
|
|
Assignee | |
Comment 3•13 years ago
|
||
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 16
|
|
Assignee | |
Comment 4•13 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
You need to log in
before you can comment on or make changes to this bug.
Description
•