Created attachment 633513 [details] [diff] [review] patch v1 The about:newtab test suite should not inject its test data directly into NewTabUtils' objects. We should rather modify the DOMStorage values and add visits to the history service. This way we'll also get test coverage of the components responsible for handling those storages. Also, it's harder to create leaking tests that way. Those are the changes: * setPinnedLinks() does now write the value directly to the DOMStorage. * setLinks() operates asynchronously now and injects its links into places/history. * I needed to replace about:blank with http://example.com/ because the history service rejects about:blank URIs.
Try is green: https://tbpl.mozilla.org/?tree=Try&rev=48e9a7c2c739
Target Milestone: --- → Firefox 16
Status: ASSIGNED → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.