The default bug view has changed. See this FAQ.

[New Tab Page] test suite should make use of underlying storages

RESOLVED FIXED in Firefox 16

Status

()

Firefox
Tabbed Browser
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: ttaubert, Assigned: ttaubert)

Tracking

Trunk
Firefox 16
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
Created attachment 633513 [details] [diff] [review]
patch v1

The about:newtab test suite should not inject its test data directly into NewTabUtils' objects. We should rather modify the DOMStorage values and add visits to the history service. This way we'll also get test coverage of the components responsible for handling those storages. Also, it's harder to create leaking tests that way.

Those are the changes:

* setPinnedLinks() does now write the value directly to the DOMStorage.
* setLinks() operates asynchronously now and injects its links into places/history.
* I needed to replace about:blank with http://example.com/ because the history service rejects about:blank URIs.
Attachment #633513 - Flags: review?(dao)
(Assignee)

Comment 1

5 years ago
Try is green:

https://tbpl.mozilla.org/?tree=Try&rev=48e9a7c2c739
(Assignee)

Updated

5 years ago
Attachment #633513 - Flags: review?(mak77)
(Assignee)

Comment 2

5 years ago
Anyone, please?
Attachment #633513 - Flags: review?(mak77)
Attachment #633513 - Flags: review?(dao)
Attachment #633513 - Flags: review+
(Assignee)

Comment 3

5 years ago
https://hg.mozilla.org/integration/fx-team/rev/eb12d458e0fb
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 16
(Assignee)

Comment 4

5 years ago
https://hg.mozilla.org/mozilla-central/rev/eb12d458e0fb
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Depends on: 780135
You need to log in before you can comment on or make changes to this bug.