Created attachment 633513 [details] [diff] [review]
The about:newtab test suite should not inject its test data directly into NewTabUtils' objects. We should rather modify the DOMStorage values and add visits to the history service. This way we'll also get test coverage of the components responsible for handling those storages. Also, it's harder to create leaking tests that way.
Those are the changes:
* setPinnedLinks() does now write the value directly to the DOMStorage.
* setLinks() operates asynchronously now and injects its links into places/history.
* I needed to replace about:blank with http://example.com/ because the history service rejects about:blank URIs.
Try is green: