765270 - JS Errors: TypeError and a Warning when 'Find on Page' is closed

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Aaron Train [:aaronmt]]

E/GeckoConsole( 4419): [JavaScript Error: "Warning: findClosed() called while _findInProgress is false!" {file: "chrome://browser/content/browser.js" line: 3209}]

E/GeckoConsole( 4419): [JavaScript Error: "TypeError: this._find is null" {file: "chrome://browser/content/browser.js" line: 3213}]

Comment 1

[:Margaret Leibovic]

Do you have STR? This shouldn't happen, so it may indicate some other bug. To be safe, though, we should probably put a check to see if this._find is null if this._findInProgress is false:

http://mxr.mozilla.org/mozilla-central/source/mobile/android/chrome/content/browser.js#3209

Comment 2

[Aaron Train [:aaronmt]]

STR: i) about: ii) Open 'Find in Page' iii) Close 'Find in Page'

Comment 3

[:Margaret Leibovic]

Attachment: patch

The problem here is that we're getting a "FindInPage:Closed" without ever getting a "FindInPage:Find". Looking at the code, _findInProgress is only ever set to true in doFind where all the other variables are initialized, so if it's false, there's nothing to do and we can just bail on the cleanup.

Comment 4

[:Margaret Leibovic]

https://hg.mozilla.org/integration/mozilla-inbound/rev/122609f13db4

Comment 5

[:Margaret Leibovic]

Comment on attachment 634189 [details] [diff] [review]
patch

[Approval Request Comment]
Bug caused by (feature/regressing bug #): JS errors introduced by bug 695172
User impact if declined: JS errors will appear in logs
Testing completed (on m-c, etc.): just landed on inbound
Risk to taking this patch (and alternatives if risky): low-risk, just prevents JS errors
String or UUID changes made by this patch: n/a

Comment 6

[Alex Keybl [:akeybl]]

Comment on attachment 634189 [details] [diff] [review]
patch

[Triage Comment]
Simple, low risk fix to prevent JS errors.

Comment 7

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/122609f13db4

Comment 8

[:Margaret Leibovic]

https://hg.mozilla.org/releases/mozilla-aurora/rev/eb20dbdfa597

Comment 9

[Adrian Tamas (:AdrianT)]

No error seen in console anymore.

Verified on:
Nightly 16.0a1 2012-07-11/Aurora 15.0a2 2012-07-11
HTC Desire
Android 2.2.2