Closed Bug 765270 Opened 12 years ago Closed 12 years ago

JS Errors: TypeError and a Warning when 'Find on Page' is closed

Categories

(Firefox for Android Graveyard :: General, defect)

ARM
Android
defect
Not set
normal

Tracking

(firefox15 verified, firefox16 verified)

VERIFIED FIXED
Firefox 16
Tracking Status
firefox15 --- verified
firefox16 --- verified

People

(Reporter: aaronmt, Assigned: Margaret)

References

Details

Attachments

(1 file)

E/GeckoConsole( 4419): [JavaScript Error: "Warning: findClosed() called while _findInProgress is false!" {file: "chrome://browser/content/browser.js" line: 3209}]

E/GeckoConsole( 4419): [JavaScript Error: "TypeError: this._find is null" {file: "chrome://browser/content/browser.js" line: 3213}]
Do you have STR? This shouldn't happen, so it may indicate some other bug. To be safe, though, we should probably put a check to see if this._find is null if this._findInProgress is false:

http://mxr.mozilla.org/mozilla-central/source/mobile/android/chrome/content/browser.js#3209
STR: i) about: ii) Open 'Find in Page' iii) Close 'Find in Page'
Attached patch patchSplinter Review
The problem here is that we're getting a "FindInPage:Closed" without ever getting a "FindInPage:Find". Looking at the code, _findInProgress is only ever set to true in doFind where all the other variables are initialized, so if it's false, there's nothing to do and we can just bail on the cleanup.
Assignee: nobody → margaret.leibovic
Attachment #634189 - Flags: review?(mark.finkle)
Attachment #634189 - Flags: review?(mark.finkle) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/122609f13db4
Target Milestone: --- → Firefox 16
Blocks: find
Comment on attachment 634189 [details] [diff] [review]
patch

[Approval Request Comment]
Bug caused by (feature/regressing bug #): JS errors introduced by bug 695172
User impact if declined: JS errors will appear in logs
Testing completed (on m-c, etc.): just landed on inbound
Risk to taking this patch (and alternatives if risky): low-risk, just prevents JS errors
String or UUID changes made by this patch: n/a
Attachment #634189 - Flags: approval-mozilla-aurora?
Comment on attachment 634189 [details] [diff] [review]
patch

[Triage Comment]
Simple, low risk fix to prevent JS errors.
Attachment #634189 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
https://hg.mozilla.org/mozilla-central/rev/122609f13db4
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
No error seen in console anymore.

Verified on:
Nightly 16.0a1 2012-07-11/Aurora 15.0a2 2012-07-11
HTC Desire
Android 2.2.2
Status: RESOLVED → VERIFIED
tracking-fennec: ? → ---
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.