Last Comment Bug 765302 - add noScriptRval option to evaluate()
: add noScriptRval option to evaluate()
Status: RESOLVED FIXED
[js:t]
:
Product: Core
Classification: Components
Component: JavaScript Engine (show other bugs)
: Other Branch
: All All
: -- normal (vote)
: mozilla16
Assigned To: Jason Orendorff [:jorendorff]
:
: Jason Orendorff [:jorendorff]
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-06-15 10:52 PDT by Jason Orendorff [:jorendorff]
Modified: 2012-06-26 01:58 PDT (History)
2 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
v1 (3.91 KB, patch)
2012-06-15 10:53 PDT, Jason Orendorff [:jorendorff]
luke: review+
Details | Diff | Splinter Review

Description Jason Orendorff [:jorendorff] 2012-06-15 10:52:38 PDT
Bug 755808 was awesome, let's do another one of those.
Comment 1 Jason Orendorff [:jorendorff] 2012-06-15 10:53:39 PDT
Created attachment 633581 [details] [diff] [review]
v1
Comment 2 Luke Wagner [:luke] 2012-06-15 11:07:51 PDT
Comment on attachment 633581 [details] [diff] [review]
v1

Review of attachment 633581 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/shell/js.cpp
@@ +832,5 @@
> +        if (!JSVAL_IS_VOID(v)) {
> +            JSBool b;
> +            if (!JS_ValueToBoolean(cx, v, &b))
> +                return false;
> +            noScriptRval = !!b;

We turned off whatever lame MSVC warning used to warn about this so you can leave off the ever-so-attractive !! if you'd like.
Comment 3 Ed Morley [:emorley] 2012-06-26 01:58:19 PDT
https://hg.mozilla.org/mozilla-central/rev/892392714fc2

Note You need to log in before you can comment on or make changes to this bug.