add noScriptRval option to evaluate()

RESOLVED FIXED in mozilla16

Status

()

Core
JavaScript Engine
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: jorendorff, Assigned: jorendorff)

Tracking

Other Branch
mozilla16
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [js:t])

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
Bug 755808 was awesome, let's do another one of those.
(Assignee)

Comment 1

5 years ago
Created attachment 633581 [details] [diff] [review]
v1
Assignee: general → jorendorff
Attachment #633581 - Flags: review?(luke)

Comment 2

5 years ago
Comment on attachment 633581 [details] [diff] [review]
v1

Review of attachment 633581 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/shell/js.cpp
@@ +832,5 @@
> +        if (!JSVAL_IS_VOID(v)) {
> +            JSBool b;
> +            if (!JS_ValueToBoolean(cx, v, &b))
> +                return false;
> +            noScriptRval = !!b;

We turned off whatever lame MSVC warning used to warn about this so you can leave off the ever-so-attractive !! if you'd like.
Attachment #633581 - Flags: review?(luke) → review+
Whiteboard: [js:t]

Comment 3

5 years ago
https://hg.mozilla.org/mozilla-central/rev/892392714fc2
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla16
You need to log in before you can comment on or make changes to this bug.