Closed
Bug 765302
Opened 13 years ago
Closed 13 years ago
add noScriptRval option to evaluate()
Categories
(Core :: JavaScript Engine, defect)
Tracking
()
RESOLVED
FIXED
mozilla16
People
(Reporter: jorendorff, Assigned: jorendorff)
Details
(Whiteboard: [js:t])
Attachments
(1 file)
|
3.91 KB,
patch
|
luke
:
review+
|
Details | Diff | Splinter Review |
Bug 755808 was awesome, let's do another one of those.
|
Assignee | |
Comment 1•13 years ago
|
||
Assignee: general → jorendorff
Attachment #633581 -
Flags: review?(luke)
|
||
Comment 2•13 years ago
|
||
Comment on attachment 633581 [details] [diff] [review]
v1
Review of attachment 633581 [details] [diff] [review]:
-----------------------------------------------------------------
::: js/src/shell/js.cpp
@@ +832,5 @@
> + if (!JSVAL_IS_VOID(v)) {
> + JSBool b;
> + if (!JS_ValueToBoolean(cx, v, &b))
> + return false;
> + noScriptRval = !!b;
We turned off whatever lame MSVC warning used to warn about this so you can leave off the ever-so-attractive !! if you'd like.
Attachment #633581 -
Flags: review?(luke) → review+
|
||
Updated•13 years ago
|
Whiteboard: [js:t]
|
||
Comment 3•13 years ago
|
||
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla16
You need to log in
before you can comment on or make changes to this bug.
Description
•