The default bug view has changed. See this FAQ.

script->types is getting thrown out too soon in JSScript::ensureRanAnalysis

RESOLVED FIXED in mozilla16

Status

()

Core
JavaScript Engine
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: billm, Assigned: billm)

Tracking

unspecified
mozilla16
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [js:t])

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
Created attachment 633588 [details] [diff] [review]
patch

The problem is that we call script->ensureHasTypes at the top of JSScript::ensureRanAnalysis. A little later, we call something that expects script->types to be non-NULL. If we GC in the middle, we get failures. I found this while running with GC zeal.

This may or may not be the right fix, but it worked for me.
Attachment #633588 - Flags: review?(bhackett1024)
Attachment #633588 - Flags: review?(bhackett1024) → review+
Whiteboard: [js:t]
(Assignee)

Comment 1

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/868fd5e81dd7
Target Milestone: --- → mozilla16
https://hg.mozilla.org/mozilla-central/rev/868fd5e81dd7
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.