Last Comment Bug 765341 - Make js_ValueToAtom's signature more normal (return JSAtom* rather than bool+redundant JSAtom** outparam)
: Make js_ValueToAtom's signature more normal (return JSAtom* rather than bool+...
Status: RESOLVED FIXED
[js:t]
:
Product: Core
Classification: Components
Component: JavaScript Engine (show other bugs)
: unspecified
: All All
: -- minor (vote)
: mozilla16
Assigned To: Jeff Walden [:Waldo] (remove +bmo to email)
:
: Jason Orendorff [:jorendorff]
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-06-15 12:36 PDT by Jeff Walden [:Waldo] (remove +bmo to email)
Modified: 2012-06-20 08:02 PDT (History)
2 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Patch (7.63 KB, patch)
2012-06-15 12:36 PDT, Jeff Walden [:Waldo] (remove +bmo to email)
sphink: review+
Details | Diff | Splinter Review

Description Jeff Walden [:Waldo] (remove +bmo to email) 2012-06-15 12:36:15 PDT
Created attachment 633629 [details] [diff] [review]
Patch

This is practically trivial rs=-land, but for an API change I feel like I should record a bug for it, probably.
Comment 1 Steve Fink [:sfink] [:s:] 2012-06-15 13:01:31 PDT
Comment on attachment 633629 [details] [diff] [review]
Patch

Review of attachment 633629 [details] [diff] [review]:
-----------------------------------------------------------------

r+ on the change, r- on the bug title. This creates js::ToAtom, which follows the pattern of js::ToObject and js::ToString, but differs from js::ToNumber, js::ToUint32, js::ToInteger, js::ToPrimitive, and every JSAPI function that takes an initial JSContext* and returns a bool. I don't know how many calls we have that take a leading JSContext*, return non-bool, and might set a pending exception.

(That said, I'm fine with the change.)

Note You need to log in before you can comment on or make changes to this bug.