Closed Bug 765341 Opened 7 years ago Closed 7 years ago

Make js_ValueToAtom's signature more normal (return JSAtom* rather than bool+redundant JSAtom** outparam)

Categories

(Core :: JavaScript Engine, defect, minor)

defect
Not set
minor

Tracking

()

RESOLVED FIXED
mozilla16

People

(Reporter: Waldo, Assigned: Waldo)

Details

(Whiteboard: [js:t])

Attachments

(1 file)

Attached patch PatchSplinter Review
This is practically trivial rs=-land, but for an API change I feel like I should record a bug for it, probably.
Attachment #633629 - Flags: review?(sphink)
Comment on attachment 633629 [details] [diff] [review]
Patch

Review of attachment 633629 [details] [diff] [review]:
-----------------------------------------------------------------

r+ on the change, r- on the bug title. This creates js::ToAtom, which follows the pattern of js::ToObject and js::ToString, but differs from js::ToNumber, js::ToUint32, js::ToInteger, js::ToPrimitive, and every JSAPI function that takes an initial JSContext* and returns a bool. I don't know how many calls we have that take a leading JSContext*, return non-bool, and might set a pending exception.

(That said, I'm fine with the change.)
Attachment #633629 - Flags: review?(sphink) → review+
Whiteboard: [js:t]
https://hg.mozilla.org/mozilla-central/rev/94dd2b2a8216
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla16
You need to log in before you can comment on or make changes to this bug.