Closed Bug 765372 Opened 11 years ago Closed 11 years ago

Add some null safety to isElementClickable

Categories

(Firefox for Android Graveyard :: General, defect)

Product:
Firefox for Android Graveyard
Component:
General
Platform:
ARM
Android
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox15 fixed, firefox16 fixed)

Status:
RESOLVED FIXED
Milestone:
Firefox 16
Tracking Flags:
Tracking Status
firefox15 --- fixed
firefox16 --- fixed

People

(Reporter: Margaret, Assigned: Margaret)

References

Details

Attachments

(1 file)

patch
1.28 KB, patch
wesj
: review+
Details | Diff | Splinter Review
Attached patch patch — — Splinter Review 
If we call isElementClickable aAllowBodyListeners=false, if aElement isn't a descendant of aElement.ownerDocument.body (such as the root element) you can run into problems. This is what causes this error sometimes seen during development:
[JavaScript Error: "NS_ERROR_INVALID_POINTER: Component returned failure code: 0x80004003 (NS_ERROR_INVALID_POINTER) [nsIEventListenerService.getListenerInfoFor]" {file: "chrome://browser/content/browser.js" line: 3397}]
Attachment #633675 - Flags: review?(wjohnston)
Assignee: nobody → margaret.leibovic
Wes gave me an r+ on IRC, so I landed this:
https://hg.mozilla.org/integration/mozilla-inbound/rev/c6371662e21e
Target Milestone: --- → Firefox 16
Backed out in https://hg.mozilla.org/integration/mozilla-inbound/rev/e4861bc9f86f - other than the orange in mochitests 1-3 and 6-8, robocop, crashtests and reftests, everything when swimmingly with that push.
I pushed to try to make sure this patch wasn't the guilty one. Re-landing:
https://hg.mozilla.org/integration/mozilla-inbound/rev/526235473719
Attachment #633675 - Flags: review?(wjohnston) → review+
https://hg.mozilla.org/mozilla-central/rev/526235473719
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Uplifted to aurora as part of a roll-up patch:
https://hg.mozilla.org/releases/mozilla-aurora/rev/2fb0a358eaf6
status-firefox15: --- → fixed
status-firefox16: --- → fixed
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.