Closed
Bug 765423
Opened 12 years ago
Closed 12 years ago
Update security group to mailing list mappings
Categories
(bugzilla.mozilla.org :: Extensions, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: reed, Unassigned)
Details
Attachments
(1 file, 1 obsolete file)
2.29 KB,
patch
|
glob
:
review+
|
Details | Diff | Splinter Review |
As per discussion with dveditz, updating the security group --> mailing list mappings, including adding support for more than one list.
Attachment #633743 -
Flags: review?(glob)
Comment on attachment 633743 [details] [diff] [review]
patch - v1
untested patch:
Global symbol "$group_to_cc_map" requires explicit package name at ./extensions/BMO/Extension.pm line 344.
Global symbol "$group_to_cc_map" requires explicit package name at ./extensions/BMO/Extension.pm line 345.
BEGIN not safe after errors--compilation aborted at ./extensions/BMO/Extension.pm line 755.
should be:
if (exists $group_to_cc_map{$group}) {
foreach my $login (@{ $group_to_cc_map{$group} }) {
my $id = login_to_id($login);
$recipients->{$id}->{+REL_CC} = Bugzilla::BugMail::BIT_DIRECT();
}
}
Attachment #633743 -
Flags: review?(glob) → review-
Reporter | ||
Comment 2•12 years ago
|
||
still untested.
Attachment #633743 -
Attachment is obsolete: true
Attachment #634282 -
Flags: review?(glob)
Comment on attachment 634282 [details] [diff] [review]
patch - v2 (untested)
r=glob
Attachment #634282 -
Flags: review?(glob) → review+
Reporter | ||
Comment 4•12 years ago
|
||
Committing to: bzr+ssh://bzr.mozilla.org/bmo/4.0/
modified extensions/BMO/Extension.pm
modified extensions/BMO/lib/Data.pm
Committed revision 8217.
Committing to: bzr+ssh://bzr.mozilla.org/bmo/4.2/
modified extensions/BMO/Extension.pm
modified extensions/BMO/lib/Data.pm
Committed revision 8209.
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Updated•5 years ago
|
Assignee: reed → nobody
Component: Extensions: BMO → Extensions
You need to log in
before you can comment on or make changes to this bug.
Description
•