Update security group to mailing list mappings

RESOLVED FIXED

Status

()

defect
RESOLVED FIXED
7 years ago
7 years ago

People

(Reporter: reed, Assigned: reed)

Tracking

Production

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

Posted patch patch - v1 (obsolete) — Splinter Review
As per discussion with dveditz, updating the security group --> mailing list mappings, including adding support for more than one list.
Attachment #633743 - Flags: review?(glob)
Comment on attachment 633743 [details] [diff] [review]
patch - v1

untested patch:

Global symbol "$group_to_cc_map" requires explicit package name at ./extensions/BMO/Extension.pm line 344.
Global symbol "$group_to_cc_map" requires explicit package name at ./extensions/BMO/Extension.pm line 345.
BEGIN not safe after errors--compilation aborted at ./extensions/BMO/Extension.pm line 755.

should be:

    if (exists $group_to_cc_map{$group}) {
        foreach my $login (@{ $group_to_cc_map{$group} }) {
            my $id = login_to_id($login);
            $recipients->{$id}->{+REL_CC} = Bugzilla::BugMail::BIT_DIRECT();
        }
    }
Attachment #633743 - Flags: review?(glob) → review-
still untested.
Attachment #633743 - Attachment is obsolete: true
Attachment #634282 - Flags: review?(glob)
Comment on attachment 634282 [details] [diff] [review]
patch - v2 (untested)

r=glob
Attachment #634282 - Flags: review?(glob) → review+
Committing to: bzr+ssh://bzr.mozilla.org/bmo/4.0/
modified extensions/BMO/Extension.pm
modified extensions/BMO/lib/Data.pm
Committed revision 8217.

Committing to: bzr+ssh://bzr.mozilla.org/bmo/4.2/
modified extensions/BMO/Extension.pm
modified extensions/BMO/lib/Data.pm
Committed revision 8209.
Status: ASSIGNED → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.