765466 - Implement click-to-play plugins management for feed messages

Status: RESOLVED FIXED

(SeaMonkey :: MailNews: Message Display, enhancement)

Description

[Jens Hatlak (:InvisibleSmiley)]

Bug 743312 and bug 747519 implemented click-to-play plugins management for the browser (plugin area click handler plus UI in the form of doorhanger or notification bar). MailNews needs similar support for feed messages, too so you can choose to allow plugins temporarily or permanently for a certain site.

Since we have no doorhangers in MailNews, providing notification bars should be enough (in addition to the plugin area click handler).

If full management UI is considered too much for MailNews (one can always use the browser or Data Manager for these tasks), we should at least implement the plugin area click handler to temporarily enable individual plugin instances.

Comment 1

[[e-mail]]

This should just be a case of adding a <notificationbox> to the appropriate windows, which should then do the rest automagically.

Comment 2

[Jens Hatlak (:InvisibleSmiley)]

(In reply to [e-mail] from comment #1)
> This should just be a case of adding a <notificationbox> to the appropriate
> windows, which should then do the rest automagically.

Even if that worked: As I said, MailNews has no doorhangers, to it would only work if you had doorhangers disabled (or did you talk about the plugin area click handler?).

Comment 3

[Philip Chee]

Well I'd hang on for a while. Once ewong's notificationbox patch for Thunderbird lands and he ports that to SeaMonkey adding click-to-play notifictions should be easier.
TB Bug 562048
SM Bug 633937

Comment 4

[[e-mail]]

(In reply to Jens Hatlak from comment #2)
> (In reply to comment #1)
> > This should just be a case of adding a <notificationbox> to the appropriate
> > windows, which should then do the rest automagically.
> 
> Even if that worked: As I said, MailNews has no doorhangers, to it would
> only work if you had doorhangers disabled (or did you talk about the plugin
> area click handler?).

Don't worry, <notificationbox> is way cleverer than that. While navigator.js turns on doorhanger support for the tabbrowser, other notificationboxes don't even know that doorhangers are enabled.

(In reply to Philip Chee from comment #3)
> Well I'd hang on for a while. Once ewong's notificationbox patch for
> Thunderbird lands and he ports that to SeaMonkey adding click-to-play
> notifications should be easier.
> TB Bug 562048
> SM Bug 633937

Sure, but we may need to backport the click-to-play plugins management to aurora.

Comment 5

[[e-mail]]

Attachment: Proposed patch

Obviously the msgNotificationBar deck will go away at some point.

Anyone got any good ideas as to what to do about those long lines?

Comment 6

[Jens Hatlak (:InvisibleSmiley)]

Comment on attachment 636688 [details] [diff] [review]
Proposed patch

Tested MailNews main and standalone windows, single plugin activation through single clicking a plugin instance, Activate Plugins and Remember Choice (or whatever it's called) from the notification bar (in MailNews, got a doorhanger in the browser as expected without changing a pref). All working fine, f=me. Thanks!

(In reply to [e-mail] from comment #5)
> Anyone got any good ideas as to what to do about those long lines?

Don't know what you mean, but I guess I'm less picky.

Comment 7

[Karsten Düsterloh]

Comment on attachment 636688 [details] [diff] [review]
Proposed patch

(In reply to [e-mail] from comment #5)
> Anyone got any good ideas as to what to do about those long lines?

Leave them as is. The 80 columns limit is a bit overrated these days. ;-)

Comment 8

[[e-mail]]

Pushed comm-central changeset 0eb2a5d6ba93.