Closed Bug 765468 Opened 8 years ago Closed 8 years ago

Use a dictionary for the argument to the XMLHttpRequest constructor

Categories

(Core :: DOM: Core & HTML, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla16

People

(Reporter: Ms2ger, Assigned: Ms2ger)

References

Details

(Whiteboard: [qa-])

Attachments

(2 files)

Attached patch Patch v1Splinter Review
No description provided.
Attachment #633780 - Flags: review?(mounir)
(Patch depends on bug 763814.)
Mmm.  This would be way simpler if we just converted an optional dictionary that's not passed into a dictionary value with all values default, wouldn't it?  Then you would't need all that Nullable gunk....
Comment on attachment 633780 [details] [diff] [review]
Patch v1

Review of attachment 633780 [details] [diff] [review]:
-----------------------------------------------------------------

I do not think I am the best suited to review that.
Redirecting to khuey.
Attachment #633780 - Flags: review?(mounir) → review?(khuey)
Comment on attachment 633780 [details] [diff] [review]
Patch v1

r=me
Attachment #633780 - Flags: review?(khuey) → review+
Attached patch Fix testSplinter Review
This test broke, so I fixed it (and added some more coverage, just for fun).
Attachment #634964 - Flags: review?(bzbarsky)
Comment on attachment 634964 [details] [diff] [review]
Fix test

r=me
Attachment #634964 - Flags: review?(bzbarsky) → review+
https://hg.mozilla.org/mozilla-central/rev/d341aed9218c
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla16
Whiteboard: [qa-]
Component: DOM: Mozilla Extensions → DOM
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.