765468 - Use a dictionary for the argument to the XMLHttpRequest constructor

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Attachment: Patch v1

Comment 1

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

(Patch depends on bug 763814.)

Comment 2

[Boris Zbarsky [:bzbarsky]]

Mmm.  This would be way simpler if we just converted an optional dictionary that's not passed into a dictionary value with all values default, wouldn't it?  Then you would't need all that Nullable gunk....

Comment 3

[Mounir Lamouri (:mounir)]

Comment on attachment 633780 [details] [diff] [review]
Patch v1

Review of attachment 633780 [details] [diff] [review]:
-----------------------------------------------------------------

I do not think I am the best suited to review that.
Redirecting to khuey.

Comment 4

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 633780 [details] [diff] [review]
Patch v1

r=me

Comment 5

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Attachment: Fix test

This test broke, so I fixed it (and added some more coverage, just for fun).

Comment 6

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 634964 [details] [diff] [review]
Fix test

r=me

Comment 7

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

https://hg.mozilla.org/mozilla-central/rev/d341aed9218c