Note: There are a few cases of duplicates in user autocompletion which are being worked on.

Use a dictionary for the argument to the XMLHttpRequest constructor

RESOLVED FIXED in mozilla16

Status

()

Core
DOM
RESOLVED FIXED
5 years ago
4 years ago

People

(Reporter: Ms2ger, Assigned: Ms2ger)

Tracking

Trunk
mozilla16
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [qa-])

Attachments

(2 attachments)

(Assignee)

Description

5 years ago
Created attachment 633780 [details] [diff] [review]
Patch v1
Attachment #633780 - Flags: review?(mounir)
(Assignee)

Comment 1

5 years ago
(Patch depends on bug 763814.)

Comment 2

5 years ago
Mmm.  This would be way simpler if we just converted an optional dictionary that's not passed into a dictionary value with all values default, wouldn't it?  Then you would't need all that Nullable gunk....
Comment on attachment 633780 [details] [diff] [review]
Patch v1

Review of attachment 633780 [details] [diff] [review]:
-----------------------------------------------------------------

I do not think I am the best suited to review that.
Redirecting to khuey.
Attachment #633780 - Flags: review?(mounir) → review?(khuey)

Comment 4

5 years ago
Comment on attachment 633780 [details] [diff] [review]
Patch v1

r=me
Attachment #633780 - Flags: review?(khuey) → review+
(Assignee)

Comment 5

5 years ago
Created attachment 634964 [details] [diff] [review]
Fix test

This test broke, so I fixed it (and added some more coverage, just for fun).
Attachment #634964 - Flags: review?(bzbarsky)

Comment 6

5 years ago
Comment on attachment 634964 [details] [diff] [review]
Fix test

r=me
Attachment #634964 - Flags: review?(bzbarsky) → review+
(Assignee)

Comment 7

5 years ago
https://hg.mozilla.org/mozilla-central/rev/d341aed9218c
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla16

Updated

5 years ago
Whiteboard: [qa-]
Component: DOM: Mozilla Extensions → DOM
Product: Core → Core
You need to log in before you can comment on or make changes to this bug.