Closed Bug 765491 Opened 12 years ago Closed 12 years ago

Paste Disabled After Copy from a Source That Is Not a Compose Window (SeaMonkey part, port Thunderbird bug 719413)

Categories

(SeaMonkey :: MailNews: Composition, defect)

defect
Not set
minor

Tracking

(Not tracked)

RESOLVED INCOMPLETE

People

(Reporter: tonymec, Unassigned)

References

Details

(Keywords: qawanted, Whiteboard: [needs repro, or of bug 330868, on SeaMonkey])

Attachments

(1 file)

Port Thunderbird bug 719413 to SeaMonkey. This is the UI part of bug 330868. Patch follows.
Attached patch patch v0Splinter Review
Attachment #633808 - Flags: ui-review?(neil)
Attachment #633808 - Flags: review?(mnyromyr)
Attachment #633808 - Flags: ui-review?(neil) → ui-review+
Comment on attachment 633808 [details] [diff] [review]
patch v0

Tony: Given that I can't even replicate the actual bug with "Mozilla/5.0 (X11; Linux x86_64; rv:16.0) Gecko/16.0 Firefox/16.0a1 SeaMonkey/2.13a1Build" (20120611193842) under Linux, I have to trust that you see a change in behaviour with this patch?
(In reply to Karsten Düsterloh from comment #2)
> Comment on attachment 633808 [details] [diff] [review]
> patch v0
> 
> Tony: Given that I can't even replicate the actual bug with "Mozilla/5.0
> (X11; Linux x86_64; rv:16.0) Gecko/16.0 Firefox/16.0a1
> SeaMonkey/2.13a1Build" (20120611193842) under Linux, I have to trust that
> you see a change in behaviour with this patch?

I confess I haven't tried; but my understanding was that this one-liner in forked code was necessary for the fix of Core bug 330868, and I didn't want SeaMonkey to lag behind Thunderbird.

I named you as reviewer with the understanding that you would know the ins and outs of the question better than me, and that you would be able to see if the patch was incomplete or unneeded. I'll leave it to you to decide between WONTFIX (i.e. leave it then and there), r- with comments (and I'll address your comments) or r+ (i.e. proceed with checkin-needed).
P.S. When I saw that bug 719413 had been reported for Core then fixed for Thunderbird, my curiosity was piqued and I ran a simple mxr search for a second instance of the same function in suite code. I found it; and I had a few misgivings about fixing it myself, but it looked simple enough, and I thought that the "UI tsar" or the "mailnews emperor" might be able to see hidden snags if there were any.
I think the first step to porting anything is to see if you can replicate the bug(gy behaviour) prior to porting. Otherwise how can you tell that your patch is working?
Attachment #633808 - Flags: review?(mnyromyr) → review?
(In reply to Philip Chee from comment #5)
> I think the first step to porting anything is to see if you can replicate
> the bug(gy behaviour) prior to porting. Otherwise how can you tell that your
> patch is working?

This patch is the (forked) UI part of a Core patch which is "Reproducible: Sometimes" and which I haven't been able to reproduce; so IIUC the patch is ready AFAICT, but someone else will have to get review for it and request checkin for it.
Assignee: antoine.mechelynck → nobody
Target Milestone: seamonkey2.13 → ---
Keywords: qawanted
Whiteboard: [needs repro, or of bug 330868, on SeaMonkey]
I cannot reproduce the bug either. Tested on Linux, following the steps in bug 330868 comment 26:

0. Have something on the clipboard
1. Open a Compose window, write something to the mail body
2. Context-click the mail body; Paste is enabled
3. Clear the clipboard (console command: xsel -bc)
4. Re-focus the Compose window mail body, context-click mail body; Paste is disabled
5. Select some part of the mail body, context-click mail body

Result for me after step 5: Paste is enabled. If this bug was valid, it would still be disabled.

[Also checked replacing step 5 by selecting something in the console. Same result.]

I guess the reason is that messengercompose.xul loads utilityOverlay (xul + js) which AFAICS takes care of cmd_paste updating. No idea whether TB handles this differently; didn't check.

Suggesting WFM unless someone can else can reproduce given the steps above (or similar).
OK. Well, if someone comes around with the problem, try building (on try or on your own machine) with the attached patch (unbitrotten if necessary).

If no one comes around who can reproduce the bug then maybe after some "reasonable" time this bug can be resolved INCOMPLETE.
Status: ASSIGNED → UNCONFIRMED
Ever confirmed: false
Whiteboard: [needs repro, or of bug 330868, on SeaMonkey] → [needs repro, or of bug 330868, on SeaMonkey][CLOSEME 2012-09-01 INCO]
Resolved per whiteboard
Status: UNCONFIRMED → RESOLVED
Closed: 12 years ago
Resolution: --- → INCOMPLETE
Whiteboard: [needs repro, or of bug 330868, on SeaMonkey][CLOSEME 2012-09-01 INCO] → [needs repro, or of bug 330868, on SeaMonkey]
Attachment #633808 - Flags: review?
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: